Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow logging $page.url when url.search is disabled #10567

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented Aug 16, 2023

fixes #10526

We were allowing logging when url.hash is disabled but not when url.search is disabled. Just copied over the same thing for when url.search is disabled.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Aug 16, 2023

🦋 Changeset detected

Latest commit: 62ebbfd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eltigerchino eltigerchino changed the title fix: allow logging$page when search is disabled fix: allow logging $page.url when search is disabled Aug 16, 2023
@eltigerchino eltigerchino changed the title fix: allow logging $page.url when search is disabled fix: allow logging $page.url when url.search is disabled Aug 16, 2023
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dummdidumm dummdidumm merged commit 32afba6 into master Aug 16, 2023
@dummdidumm dummdidumm deleted the fix-url-log-during-prerender branch August 16, 2023 13:43
@github-actions github-actions bot mentioned this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prerendering app that logs $page will incorrectly fail
2 participants