Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark cloudflare:email as external for email routing api #10404

Merged
merged 16 commits into from
Jul 27, 2023

Conversation

chientrm
Copy link
Contributor

@chientrm chientrm commented Jul 18, 2023

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Jul 18, 2023

🦋 Changeset detected

Latest commit: 3ba4b44

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sveltejs/adapter-cloudflare-workers Patch
@sveltejs/adapter-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ghostdevv
Copy link
Member

Hey, why is this needed? Do you have any links to the docs on the feature as I'm not familiar with it

@chientrm
Copy link
Contributor Author

Hey, why is this needed? Do you have any links to the docs on the feature as I'm not familiar with it

Here is the example usage: https://developers.cloudflare.com/email-routing/email-workers/send-email-workers/

Very sorry, I wanted to include the docs but there was no section in the template for it.

@ghostdevv ghostdevv changed the title patch: mark cloudflare:email as external for email routing api (beta) Mark cloudflare:email as external for email routing api Jul 21, 2023
@superboss224
Copy link

superboss224 commented Aug 26, 2023

@chientrm @benmccann
Hello,
we had an issue about node: modules not being resolved correctly, and thus making a PostgreSQL driver module unable to work on Cloudflare Pages

Could you please take a look into the issue and add node:* as well here ?

Currently, @wackfx had to make a custom driver to solve that issue but it may not be the best solution

@chientrm
Copy link
Contributor Author

chientrm commented Aug 26, 2023

Please track #10544 and #10521 .

Check out my comment on how to use my temporary adapter meanwhile: @chientrm/adapter-cloudflare

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants