fix: dynamically suggest package manager installation command in migrate scripts
#495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8717b7f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
manuel3108
changed the title
migrate script
manuel3108
requested changes
Mar 23, 2025
Member
manuel3108
left a comment
manuel3108
left a comment
There was a problem hiding this comment.
Thanks for your pr!
detect is determining the package manager based on existing or non existing lockfiles like pnpm-lock.yml etc. getUserAgent determines with which package manager the current command is being executed.
Since svelte-migrate is expected to be run on an existing project, it's totally valid to use detect here in my opinion.
manuel3108
changed the title
migrate scriptmigrate scripts
manuel3108
approved these changes
Mar 30, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates #187
Had to add package-manager-detector to the migrate package as a dependency.
I was a little confused on using
detectvs.getUserAgent--maybe you have a better understanding of when and where to use each? For this I used the barebonesdetectand it worked on my machine.