Skip to content

Conversation

@samuelstroschein
Copy link
Contributor

@samuelstroschein samuelstroschein commented Feb 28, 2025

Paraglide JS 2.0 is going to be released on Monday (March 3). This PR updates the addon to set up and use v2 of Paraglide JS.

Pre-elimnary release notes for Paraglide JS v2 can be found here

Don't merge this before v2 got released (I will write a comment when this happened. Approx second week of march)

@changeset-bot
Copy link

changeset-bot bot commented Feb 28, 2025

🦋 Changeset detected

Latest commit: 1bf9175

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 2, 2025

Open in Stackblitz

npm i https://pkg.pr.new/sveltejs/cli/sv@461
npm i https://pkg.pr.new/sveltejs/cli/svelte-migrate@461

commit: 1bf9175

Copy link
Member

@manuel3108 manuel3108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so cool. So much less boilerplate required! Nice work.

Also thanks for the PR, everything seems to be working perfectly at a first glance. Apart from the tests of course, these are failing because they are using a non existing npm version of paraglide

@samuelstroschein
Copy link
Contributor Author

Ready to merge eta next week. Getting a few edge case Paraglide JS 2.0 bug reports in. Fixing them over the weekend.

@manuel3108
Copy link
Member

Sure, just give me a heads up once it's ready!

@samuelstroschein
Copy link
Contributor Author

@manuel3108 press merge 🥳

@manuel3108
Copy link
Member

Mhmm, seems like the tests are still failing. Don't have the time to investigate this today.

@manuel3108
Copy link
Member

I still don't understand why the tests are failing here. Everything works just fine locally.

@samuelstroschein
Copy link
Contributor Author

Argh the gnarly cloud without possibilities to test locally is striking once again. @manuel3108 i remember that CI was green when i first opened it (ha, that doesn't help, does it?).

lmk if i can do something

@manuel3108
Copy link
Member

manuel3108 commented Mar 19, 2025

remember that CI was green when i first opened it

i think this was because at that time it did not run (iirc), as this seems to be your first contribution to your project, and we need to "whitelist" each run

@manuel3108
Copy link
Member

Ok, i think I finally found the error. The message displayed in the github action has to be converted to a buffer, than a string. This is what it was printing:

Scope: all 3 workspace projects
.. | Progress: resolved 1, reused 0, downloaded 0, added 0
/home/runner/work/cli/cli/.test-output/addons/paraglide/-1511660393_0:
 ERR_PNPM_UNSUPPORTED_ENGINE  Unsupported environment (bad pnpm and/or Node.js version)

This error happened while installing the dependencies of @inlang/[email protected]
at @inlang/[email protected]

Your Node version is incompatible with "@lix-js/[email protected]".

Expected version: >=21
Got: v18.20.7

This is happening because the package's manifest has an engines.node field specified.
To fix this issue, install the required Node version.

Locally i was already using a valid node version.
Update the node version to test against, and everything should be working now!

@samuelstroschein
Copy link
Contributor Author

@manuel3108 i am gonna invest 5 min if i can ship opral/lix-sdk#277

@manuel3108
Copy link
Member

That would be great!
Because looks like v21 is unsupported by v-p-s

Scope: all 5 workspace projects
 ERR_PNPM_UNSUPPORTED_ENGINE  Unsupported environment (bad pnpm and/or Node.js version)

Your Node version is incompatible with "@sveltejs/[email protected]([email protected])([email protected])".

Expected version: ^18.0.0 || ^20.0.0 || >=22
Got: v21.7.3

This is happening because the package's manifest has an engines.node field specified.
To fix this issue, install the required Node version.

@samuelstroschein
Copy link
Contributor Author

@manuel3108 paraglide js 2.0.4 should work. try again in approx 10 mins when opral/monorepo#3530 is deployed

@manuel3108
Copy link
Member

Everything is passing now 🎉. Thanks for your help!

@manuel3108 manuel3108 merged commit 2dcb4f0 into sveltejs:main Mar 22, 2025
11 of 12 checks passed
@github-actions github-actions bot mentioned this pull request Mar 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants