-
-
Notifications
You must be signed in to change notification settings - Fork 69
update to paraglide js v2 #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 1bf9175 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
manuel3108
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so cool. So much less boilerplate required! Nice work.
Also thanks for the PR, everything seems to be working perfectly at a first glance. Apart from the tests of course, these are failing because they are using a non existing npm version of paraglide
Co-authored-by: Manuel <[email protected]>
|
Ready to merge eta next week. Getting a few edge case Paraglide JS 2.0 bug reports in. Fixing them over the weekend. |
|
Sure, just give me a heads up once it's ready! |
|
@manuel3108 press merge 🥳 |
|
Mhmm, seems like the tests are still failing. Don't have the time to investigate this today. |
|
I still don't understand why the tests are failing here. Everything works just fine locally. |
|
Argh the gnarly cloud without possibilities to test locally is striking once again. @manuel3108 i remember that CI was green when i first opened it (ha, that doesn't help, does it?). lmk if i can do something |
i think this was because at that time it did not run (iirc), as this seems to be your first contribution to your project, and we need to "whitelist" each run |
|
Ok, i think I finally found the error. The message displayed in the github action has to be converted to a buffer, than a string. This is what it was printing:
Locally i was already using a valid node version. |
|
@manuel3108 i am gonna invest 5 min if i can ship opral/lix-sdk#277 |
|
That would be great!
|
|
@manuel3108 paraglide js 2.0.4 should work. try again in approx 10 mins when opral/monorepo#3530 is deployed |
|
Everything is passing now 🎉. Thanks for your help! |
Paraglide JS 2.0 is going to be released on Monday (March 3). This PR updates the addon to set up and use v2 of Paraglide JS.
Pre-elimnary release notes for Paraglide JS v2 can be found here
Don't merge this before v2 got released (I will write a comment when this happened. Approx second week of march)