Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tailwindcss plugins #127

Merged
merged 5 commits into from
Oct 16, 2024
Merged

feat: tailwindcss plugins #127

merged 5 commits into from
Oct 16, 2024

Conversation

manuel3108
Copy link
Member

Closes #27

Untested and with a type error, but i need to leave.
Ignored the icon plugin, since there seems to be some discrepancies in the issue.

To discuss: We recently removed the name property from the adder. Should we do the same here and only display the id?

Copy link

changeset-bot bot commented Oct 15, 2024

🦋 Changeset detected

Latest commit: a329f52

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Oct 15, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/sveltejs/cli/sv@127

commit: a329f52

@benmccann
Copy link
Member

To discuss: We recently removed the name property from the adder. Should we do the same here and only display the id?

I think so. It helps show which ones are officially maintained by the Tailwind org and which are third-party

@AdrianGonz97
Copy link
Member

AdrianGonz97 commented Oct 15, 2024

are you suggesting that we should show their npm package names instead?
ex:

◆  Which plugins would you like to add?
│  ◻ @tailwindcss/typography
│  ◻ @tailwindcss/forms
│  ◻ @tailwindcss/container-queries
│  ◻ @tailwindcss/aspect-ratio
└

as opposed too...

◆  Which plugins would you like to add?
│  ◻ Typography
│  ◻ Forms
│  ◻ Container queries
│  ◻ Aspect ratio
└

@AdrianGonz97
Copy link
Member

removing the name prop ended up being nicer. i'm also playing around with adding the npm package name as a hint as well:

img

thoughts?

@benmccann
Copy link
Member

benmccann commented Oct 15, 2024

That screenshot looks nice

@benmccann benmccann changed the title feat(DRAFT): tailwindcss plugins feat: tailwindcss plugins Oct 15, 2024
@manuel3108 manuel3108 merged commit 9fcc3ef into main Oct 16, 2024
5 checks passed
@manuel3108 manuel3108 deleted the feat/tailwindcss-plugins branch October 16, 2024 18:08
@github-actions github-actions bot mentioned this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tailwind plugins
3 participants