feat: useGelocation
#165
feat: useGelocation
#165
Conversation
🦋 Changeset detectedLatest commit: 3988221 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
||
| function updatePosition(position: GeolocationPosition) { | ||
| locatedAt = position.timestamp; | ||
| coords.accuracy = position.coords.accuracy; |
There was a problem hiding this comment.
I'm not sure if this makes sense here or if we use $state.raw for the coords. This feels more fine-grained but open to feedback.
| @@ -8,9 +8,9 @@ | |||
| export class IsSupported { | |||
| #current: boolean = $state(false); | |||
|
|
|||
| constructor(predicate: () => boolean) { | |||
There was a problem hiding this comment.
This was pretty annoying from a DX perspective not going to lie. Since certain things may be "undefined" you end up always needing to wrap it on the consumer side with Boolean rather than us just handling it which is cleaner imo
There was a problem hiding this comment.
I don't get it. Why do you need to check if navigator even exists? When will it not exist?
Besides, to make it a boolean, it would be navigator !== undefined && "geolocation" in navigator, which is more explicit. No weird truthfy/falsy business.
There was a problem hiding this comment.
I don't want to do navigation ! == undefined is the point. I want to know if it exists/is truthy, which is the type for it. It's either Navigator | undefined, and the same applies to all other Web APIs which is the entire purpose of this util. We just add more work on the consumer for no gain.
As far as when it won't exist, any non-browser environment, to which the easy button is to just slap an if (BROWSER).
But the question isn't really "are we in a browser?" but rather "can we safely use navigator?" The browser flag is just an indirect proxy for what we actually want to know, adding an extra point of potential failure without any real benefit.
Checking for navigator directly avoids all these issues - it's self-contained, accurate, and requires no maintenance.
It's also setting up what I'm looking to add in a PR which will provide support for custom window, document, navigator, etc. to support iframes, shadow doms, etc. (#167)
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Reactive access to the browser's Geolocation API.