fix: only listen for the 'storage' event if using 'local' storage #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f06f259 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Two more things: Unsure if there's anything else required, so I made this a draft PR. The second is that I added the |
huntabyte
reviewed
Dec 5, 2024
|
Done. Let me know if there are any more pendings. If not, I'll add a changeset and take the PR out of Draft status. |
|
Feel free to move it out of draft @webJose ! |
|
Thank you! |
huntabyte
approved these changes
Dec 6, 2024
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
|
Ha, you were in a hurry. I came but the branch was merged already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #150.
Notes
jsdom doesn't raise the 'storage' event because this event only fires when values change in a different window, which is something we don't have (we only have one window). So to unit-test, one must dispatch the event manually.
Also: The event handler uses
getValueFromStorageto obtain the value, but theevent.newValueproperty already has this value. This seems like an unnecessary performance hit, and may be best to simply deserializeevent.newValue.New Situation/Issue
I noticed that there is no deletion. I think that whenever
this.#currentbecomes undefined, the value in storage should be deleted.