Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes/improvements/docs #157

Merged
merged 4 commits into from
Dec 2, 2024
Merged

fixes/improvements/docs #157

merged 4 commits into from
Dec 2, 2024

Conversation

huntabyte
Copy link
Member

@huntabyte huntabyte commented Dec 2, 2024

  • Widens the type for the various utils that accept an element/element getter as a prop from MaybeGetter<HTMLElement | undefined> to MaybeGetter<HTMLElement | null | undefined>
  • Updated public methods in classes to arrow functions to avoid the dreaded this situation
  • Explicit types/return types for public interfaces
  • Some documentation improvements/additions
  • Created a new internal DemoNote component to use to provide footnotes in small text under the demos.

Copy link

changeset-bot bot commented Dec 2, 2024

🦋 Changeset detected

Latest commit: 2f6e8be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
runed Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 2, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
runed ✅ Ready (View Log) Visit Preview 2f6e8be

@huntabyte huntabyte merged commit 86a00b8 into main Dec 2, 2024
4 checks passed
@huntabyte huntabyte deleted the fixes-and-docs branch December 2, 2024 22:41
@abdel-17
Copy link
Collaborator

abdel-17 commented Dec 3, 2024

I don't agree with using arrow functions for everything. It kind of defeats the purpose of using classes. If you need it pass it down, you can just create the arrow fn yourself.

() => something.foo()

It's a quirk with classes in JS, but it's expected. Built in classes behave like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants