-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add runScheduledNow
and updateImmediately
to Debounce
#142
Merged
huntabyte
merged 10 commits into
svecosystem:main
from
Coronon:feature/useDebounce-runScheduledNow
Dec 6, 2024
Merged
feat: add runScheduledNow
and updateImmediately
to Debounce
#142
huntabyte
merged 10 commits into
svecosystem:main
from
Coronon:feature/useDebounce-runScheduledNow
Dec 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
🦋 Changeset detectedLatest commit: 7026819 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
huntabyte
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
huntabyte
changed the title
feat: add runScheduledNow and updateImmediately to debounce
feat: add Dec 6, 2024
runScheduledNow
and updateImmediately
to Debounce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
runScheduledNow
touseDebounce
andupdateImmediately
toDebounced
.Both new methods will run the most recently scheduled call now, instead of waiting for the debounce duration. They return a
Promise<void>
that resolves when the debounced call they preemptively run settles.I also added documentation for both of these new functions. I moved the new "Run now" button ahead of the "Cancel message" button for
useDebounce
because users have to click it quickly to notice the difference from the normal debounced call, whereas canceling will always be obvious.Resolves #134
Builds on top of #141
Let me know of any changes you want me to make :)