Skip to content

utillinux -> util-linux#215

Closed
SuperSandro2000 wants to merge 1 commit intosvanderburg:masterfrom
SuperSandro2000:util-linux
Closed

utillinux -> util-linux#215
SuperSandro2000 wants to merge 1 commit intosvanderburg:masterfrom
SuperSandro2000:util-linux

Conversation

@SuperSandro2000
Copy link

NixOS/nixpkgs#104776

Closes #213 for master

I know that this wont work on stable but I would like to patch this in unstable to not break nixpkgs when regenerating nodePackages.

@svanderburg
Copy link
Owner

I think we need to give this some more thought -- while this PR indeed fixes the situation in the current Nixpkgs master branch, it is somewhat impractical to no longer support the latest stable Nixpkgs.

I'm close to a new release of node2nix, but I prefer that it remains compatible with both the stable version as well as master. For most production deployments that I support, I typically use the latest stable version of Nixpkgs, not master because it is typically breaking a lot of things.

The alternative is that we need to ship two kinds of versions of node2nix: one that works with the latest stable and one with the latest master, but I'm not in favor of doing that, because it causes confusion to end-users.

@svanderburg
Copy link
Owner

I'm now working on a fix myself

@svanderburg
Copy link
Owner

I have implemented a backwards compatible fix in revision 52436bb

@SuperSandro2000
Copy link
Author

I left a comment on the commit for a case which you might have missed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update utillinux to util-linux

2 participants