utillinux -> util-linux#215
utillinux -> util-linux#215SuperSandro2000 wants to merge 1 commit intosvanderburg:masterfrom SuperSandro2000:util-linux
Conversation
|
I think we need to give this some more thought -- while this PR indeed fixes the situation in the current Nixpkgs master branch, it is somewhat impractical to no longer support the latest stable Nixpkgs. I'm close to a new release of node2nix, but I prefer that it remains compatible with both the stable version as well as master. For most production deployments that I support, I typically use the latest stable version of Nixpkgs, not master because it is typically breaking a lot of things. The alternative is that we need to ship two kinds of versions of node2nix: one that works with the latest stable and one with the latest master, but I'm not in favor of doing that, because it causes confusion to end-users. |
|
I'm now working on a fix myself |
|
I have implemented a backwards compatible fix in revision 52436bb |
|
I left a comment on the commit for a case which you might have missed. |
NixOS/nixpkgs#104776
Closes #213 for master
I know that this wont work on stable but I would like to patch this in unstable to not break nixpkgs when regenerating nodePackages.