Skip to content

nodePackages: add more coc-nvim extensions#106621

Closed
lovesegfault wants to merge 4 commits intoNixOS:masterfrom
lovesegfault:node-update
Closed

nodePackages: add more coc-nvim extensions#106621
lovesegfault wants to merge 4 commits intoNixOS:masterfrom
lovesegfault:node-update

Conversation

@lovesegfault
Copy link
Member

@lovesegfault lovesegfault commented Dec 11, 2020

Motivation for this change

Adds the coc extensions I needed and does an update of the nodePackages set.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lovesegfault lovesegfault force-pushed the node-update branch 2 times, most recently from 72e82fc to 5eabf70 Compare December 11, 2020 03:19
@ofborg ofborg bot requested review from 7c6f434c and midchildan December 11, 2020 03:29
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Dec 11, 2020
@lovesegfault
Copy link
Member Author

lovesegfault commented Dec 11, 2020

Result of nixpkgs-review pr 106621 run on x86_64-linux 1

1 package marked as broken and skipped:
  • rambox-pro
1 package failed to build:
  • matrix-recorder
65 packages built:
  • antora
  • base16-builder
  • bitwarden-cli
  • castnow
  • commitizen
  • create-cycle-app
  • emojione
  • epgstation
  • etcher
  • flood
  • gtop
  • image_optim
  • iosevka
  • joplin
  • lumo
  • mastodon-bot
  • mirakurun
  • n8n
  • netlify-cli
  • newman
  • parity-ui
  • pm2
  • postcss-cli
  • python37Packages.batchspawner
  • python37Packages.dockerspawner
  • python37Packages.jupyterhub
  • python37Packages.jupyterhub-ldapauthenticator
  • python37Packages.jupyterhub-systemdspawner
  • python37Packages.jupyterhub-tmpauthenticator
  • python37Packages.oauthenticator
  • python38Packages.batchspawner
  • python38Packages.dockerspawner
  • python38Packages.jupyterhub
  • python38Packages.jupyterhub-ldapauthenticator
  • python38Packages.jupyterhub-systemdspawner
  • python38Packages.jupyterhub-tmpauthenticator
  • python38Packages.oauthenticator
  • python39Packages.batchspawner
  • python39Packages.dockerspawner
  • python39Packages.jupyterhub
  • python39Packages.jupyterhub-ldapauthenticator
  • python39Packages.jupyterhub-systemdspawner
  • python39Packages.jupyterhub-tmpauthenticator
  • python39Packages.oauthenticator
  • redoc-cli
  • ripcord
  • slack
  • sloc
  • teleprompter
  • thelounge
  • twemoji-color-font
  • vimPlugins.coc-metals
  • vimPlugins.coc-prettier
  • vimPlugins.coc-rust-analyzer
  • vimPlugins.coc-snippets
  • vimPlugins.coc-stylelint
  • vimPlugins.coc-tslint
  • vimPlugins.coc-tsserver
  • vimPlugins.coc-vetur
  • vimPlugins.coc-yaml
  • vscode-extensions.matklad.rust-analyzer
  • vscode-extensions.ms-python.vscode-pylance
  • vscode-extensions.vadimcn.vscode-lldb
  • wasm-text-gen
  • yaml-language-server

@lovesegfault
Copy link
Member Author

lovesegfault commented Dec 11, 2020

So, the editorconfig failure is in some autogen'd files. Can it be ignored?

@lovesegfault
Copy link
Member Author

lovesegfault commented Dec 11, 2020

Result of nixpkgs-review pr 106621 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • dat
  • remarkjs
1 package failed to build:
  • matrix-recorder
68 packages built:
  • airfield
  • antora
  • base16-builder
  • bitwarden-cli
  • castnow
  • commitizen
  • create-cycle-app
  • emojione
  • epgstation
  • etcher
  • flood
  • google-clasp
  • gtop
  • image_optim
  • iosevka
  • joplin
  • lumo
  • mastodon-bot
  • mirakurun
  • n8n
  • netlify-cli
  • newman
  • nixui
  • parity-ui
  • pm2
  • postcss-cli
  • python37Packages.batchspawner
  • python37Packages.dockerspawner
  • python37Packages.jupyterhub
  • python37Packages.jupyterhub-ldapauthenticator
  • python37Packages.jupyterhub-systemdspawner
  • python37Packages.jupyterhub-tmpauthenticator
  • python37Packages.oauthenticator
  • python38Packages.batchspawner
  • python38Packages.dockerspawner
  • python38Packages.jupyterhub
  • python38Packages.jupyterhub-ldapauthenticator
  • python38Packages.jupyterhub-systemdspawner
  • python38Packages.jupyterhub-tmpauthenticator
  • python38Packages.oauthenticator
  • python39Packages.batchspawner
  • python39Packages.dockerspawner
  • python39Packages.jupyterhub
  • python39Packages.jupyterhub-ldapauthenticator
  • python39Packages.jupyterhub-systemdspawner
  • python39Packages.jupyterhub-tmpauthenticator
  • python39Packages.oauthenticator
  • redoc-cli
  • ripcord
  • slack (slack-dark)
  • sloc
  • teleprompter
  • thelounge
  • twemoji-color-font
  • vimPlugins.coc-metals
  • vimPlugins.coc-prettier
  • vimPlugins.coc-rust-analyzer
  • vimPlugins.coc-snippets
  • vimPlugins.coc-stylelint
  • vimPlugins.coc-tslint
  • vimPlugins.coc-tsserver
  • vimPlugins.coc-vetur
  • vimPlugins.coc-yaml
  • vscode-extensions.matklad.rust-analyzer
  • vscode-extensions.ms-python.vscode-pylance
  • vscode-extensions.vadimcn.vscode-lldb
  • wasm-text-gen
  • yaml-language-server

@ofborg ofborg bot requested a review from michojel December 11, 2020 05:38
@midchildan
Copy link
Member

midchildan commented Dec 13, 2020

It's not ideal, but I guess it's easier to add the newlines manually as there's only 6 files that needs fixing.

@midchildan
Copy link
Member

midchildan commented Dec 13, 2020 •
edited
Loading

I think what's bit more problematic is how util-linux is replaced with utillinux, undoing recent changes made in #104776.

This seems to have been fixed in node2nix with svanderburg/node2nix#215, but it's not released yet.

@lovesegfault
Copy link
Member Author

lovesegfault commented Dec 13, 2020

I think what's bit more problematic is how util-linux is replaced with utillinux, undoing recent changes made in #104776.

This seems to have been fixed in node2nix with svanderburg/node2nix#215, but it's not released yet.

Agreed, maybe we need to ask @svanderburg for a new release to be cut?

@lovesegfault
Copy link
Member Author

lovesegfault commented Jan 2, 2021

This will have to wait on a new node2nix.

@lovesegfault lovesegfault mentioned this pull request Feb 21, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@midchildan midchildan Awaiting requested review from midchildan

@grahamc grahamc Awaiting requested review from grahamc

@adisbladis adisbladis Awaiting requested review from adisbladis

@michojel michojel Awaiting requested review from michojel

Assignees

No one assigned

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lovesegfault @midchildan