Repository navigation
chore(problems): bump catalog submodule to surface the sample Battle's red team - #1708
Conversation
…s red team The Disruptions (red team) tab was empty because the problems submodule was pinned to de6a8f5, which predates the sample Battle getting a real red team. Bump the pin to a7ac11e (TenkaCloudChallenge main), which brings in: - #38 hello-world-battle: a real, explained red team — "frontend-down" disruption (ssm-run-command stops nginx; ADR-029 auto-revert after 600s). This is what makes the Disruptions tab non-empty so organizers can actually test the feature. - #39 microservice-migration-battle: red-team explanation in the description. - #40 problem "check engine" validator; #41 teaser ASCII-diagram fix. Also update apps/participant-portal/src/plugins/props-builder.test.ts: it used hello-world-battle as a "no disruptions" example, which is no longer true — switch the empty-case example to a challenge and pin the sample's new public disruption. To see it live, redeploy the problem-deploy backend (the event-handler Lambda bundles the catalog). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 51 minutes and 31 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1708 +/- ##
=======================================
Coverage 92.75% 92.75%
=======================================
Files 434 434
Lines 11900 11900
Branches 3655 3655
=======================================
Hits 11038 11038
Misses 295 295
Partials 567 567 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
「サンプルのバトルにレッドチームの定義がないから何もテストできない」というご指摘の原因は、problems submodule の pin が古かったことでした(
de6a8f5、サンプル Battle に red team が付く前のコミット)。実は disruption の定義は upstream(TenkaCloudChallenge)に既にあります。pin をa7ac11e(main)に bump して取り込みます。bump で入る変更(
de6a8f5..a7ac11e、いずれも安全):frontend-downdisruption(ssm-run-commandで nginx 停止 → frontend probe が 200 を返さず加点停止 → ADR-029 に従い 600 秒後に自動復旧)。これで Disruptions タブが空でなくなり、運営が機能をテストできるようになります。apps/participant-portal/src/plugins/props-builder.test.tsも更新:hello-world-battleを「disruptions 無し」の例に使っていたが、red team が付いたので例を challenge に差し替え、新しい public disruption (frontend-down/ publicHint=true) を pin。カタログは event-handler Lambda に build 時 bundle されるため、live で見るには problem-deploy backend の再 deploy が必要です(既存の "test" イベントは、disruption がイベント作成時 snapshot か live catalog 参照かで挙動が変わります。確実には bump 反映後に新規イベントを作成)。
Test plan
make validate-problems: bump 後の 7 metadata すべて有効(hello-world-battle の disruption が SCHEMA を通る)。props-builder.test.ts: 空ケースを challenge に変更、hello-world-battleがfrontend-down(publicHint=true) を返すことを pin。participant-portal 594 テスト green、coverage 100%。make harness/make before-commitgreen(全 SPA build がカタログ更新込みで通る)。Regression analysis
validate-problems/ 全 SPA build green で、新カタログがアプリの build-time discovery と整合することを確認。Physical impact