Skip to content

chore(problems): bump catalog submodule to surface the sample Battle's red team - #1708

Merged
susumutomita merged 1 commit into
mainfrom
chore/bump-problems-redteam
Jun 4, 2026
Merged

susumutomita merged 1 commit into
mainfrom
chore/bump-problems-redteam

Conversation

@susumutomita

Copy link
Copy Markdown
Owner

Summary

「サンプルのバトルにレッドチームの定義がないから何もテストできない」というご指摘の原因は、problems submodule の pin が古かったことでした(de6a8f5、サンプル Battle に red team が付く前のコミット)。実は disruption の定義は upstream(TenkaCloudChallenge)に既にあります。pin を a7ac11e(main)に bump して取り込みます。

bump で入る変更(de6a8f5..a7ac11e、いずれも安全):

apps/participant-portal/src/plugins/props-builder.test.ts も更新: hello-world-battle を「disruptions 無し」の例に使っていたが、red team が付いたので例を challenge に差し替え、新しい public disruption (frontend-down / publicHint=true) を pin。

⚠️ 反映に deploy が必要

カタログは event-handler Lambda に build 時 bundle されるため、live で見るには problem-deploy backend の再 deploy が必要です(既存の "test" イベントは、disruption がイベント作成時 snapshot か live catalog 参照かで挙動が変わります。確実には bump 反映後に新規イベントを作成)。

Test plan

  • make validate-problems: bump 後の 7 metadata すべて有効(hello-world-battle の disruption が SCHEMA を通る)。
  • props-builder.test.ts: 空ケースを challenge に変更、hello-world-battle が frontend-down(publicHint=true) を返すことを pin。participant-portal 594 テスト green、coverage 100%。
  • make harness / make before-commit green(全 SPA build がカタログ更新込みで通る)。

Regression analysis

  • submodule の gitlink 更新 + テスト 1 ファイルのみ。bump 範囲は metadata 2 件 + clone 内 validator + teaser doc で、テンプレート/スキーマの破壊的変更なし。
  • validate-problems / 全 SPA build green で、新カタログがアプリの build-time discovery と整合することを確認。

Physical impact

  • submodule pin(gitlink)の更新。CDK / CFn / IAM への変更なし → NO-OP(インフラ差分なし)。ただしカタログ内容が変わるため、problem-deploy backend を再 deploy すると event-handler Lambda の bundle が更新される。

…s red team

The Disruptions (red team) tab was empty because the problems submodule was pinned
to de6a8f5, which predates the sample Battle getting a real red team. Bump the pin to
a7ac11e (TenkaCloudChallenge main), which brings in:

- #38 hello-world-battle: a real, explained red team — "frontend-down" disruption
  (ssm-run-command stops nginx; ADR-029 auto-revert after 600s). This is what makes
  the Disruptions tab non-empty so organizers can actually test the feature.
- #39 microservice-migration-battle: red-team explanation in the description.
- #40 problem "check engine" validator; #41 teaser ASCII-diagram fix.

Also update apps/participant-portal/src/plugins/props-builder.test.ts: it used
hello-world-battle as a "no disruptions" example, which is no longer true — switch the
empty-case example to a challenge and pin the sample's new public disruption.

To see it live, redeploy the problem-deploy backend (the event-handler Lambda bundles
the catalog).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@susumutomita, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 51 minutes and 31 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e3fe5407-aa7f-4175-a345-1bd3739e1299

📥 Commits

Reviewing files that changed from the base of the PR and between c048824 and 2170af3.

📒 Files selected for processing (2)
  • apps/participant-portal/src/plugins/props-builder.test.ts
  • problems
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bump-problems-redteam

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@susumutomita
susumutomita merged commit 6cb947b into main Jun 4, 2026
8 checks passed
@susumutomita
susumutomita deleted the chore/bump-problems-redteam branch June 4, 2026 08:57
@codecov

codecov Bot commented Jun 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.75%. Comparing base (c048824) to head (2170af3).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1708   +/-   ##
=======================================
  Coverage   92.75%   92.75%           
=======================================
  Files         434      434           
  Lines       11900    11900           
  Branches     3655     3655           
=======================================
  Hits        11038    11038           
  Misses        295      295           
  Partials      567      567           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant