fix (desktop): cmd+n no project selected

[AviPeltz]

Description

Related Issues

Type of Change

• Bug fix
• New feature
• Documentation
• Refactor
• Other (please describe):

Testing

Screenshots (if applicable)

Additional Notes

Summary by CodeRabbit

• New Features
  • NEW_WORKSPACE hotkey now intelligently pre-selects the current project context when creating a new workspace, improving workflow efficiency.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

The dashboard layout now retrieves the current workspace from the matched route and uses its projectId to pre-select a project when opening the NEW_WORKSPACE hotkey modal. This enables contextual project selection based on the active workspace.

Changes

Cohort / File(s)

Summary

Route-based workspace context apps/desktop/src/renderer/routes/_authenticated/_dashboard/layout.tsx

Adds useMatchRoute and electronTrpc imports for route matching and workspace queries. Implements useMatchRoute to extract currentWorkspaceId from the route, fetches the corresponding workspace via electronTrpc.workspaces.get.useQuery (enabled conditionally), and passes currentWorkspace?.projectId to the NEW_WORKSPACE hotkey to enable project pre-selection. Updates dependency array to include currentWorkspace?.projectId.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• fix (desktop): add isPending disable on workspace creations Double enter on workspace creation #626: Modifies the NEW_WORKSPACE modal's Enter handler to require a selected projectId and prevent duplicate submissions, complementing this PR's project pre-selection feature.
• fix(desktop): add tooltip to NewWorkspace modal new project button & make sure default selected #461: Implements selectedProjectId handling and default selection behavior in NewWorkspaceModal, directly supporting the projectId parameter this PR now passes.
• fix (desktop): new workspace cmd + n #706: Wires the NEW_WORKSPACE hotkey to open the modal; this PR enhances it with route-driven contextual project data.

Poem

🐰 Through routes we hop to find the space,
A workspace matched, a project placed,
The hotkey shines with context bright,
New workspaces spring up right! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is almost entirely empty, with only the bug fix checkbox marked but all required sections lacking substantive content: Description, Related Issues, Testing, Screenshots, and Additional Notes are unfilled.	Provide a detailed description of the bug fix, link any related issues, document the testing performed, and explain the fix's impact and rationale.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: fixing the cmd+n keyboard shortcut behavior when no project is selected in the desktop application.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

• ⚠️ Neon database branch
• ⚠️ Electric Fly.io app

Thank you for your contribution! 🎉