fix (desktop): new workspace cmd + n by AviPeltz · Pull Request #706 · superset-sh/superset

AviPeltz · 2026-01-10T02:10:42Z

Description

Related Issues

Type of Change

Testing

Screenshots (if applicable)

Additional Notes

Summary by CodeRabbit

New Features
- Added keyboard shortcut support to open the New Workspace modal

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2026-01-10T02:10:51Z

📝 Walkthrough

Walkthrough

This PR wires a keyboard shortcut in the main desktop screen to trigger the New Workspace modal. It imports the useOpenNewWorkspaceModal hook, creates a handler function, and binds it to the NEW_WORKSPACE hotkey in the hotkeys dependency configuration.

Changes

Cohort / File(s)	Change Summary
Hotkey Binding for New Workspace `apps/desktop/src/renderer/screens/main/index.tsx`	Added import of `useOpenNewWorkspaceModal` hook, created local handler function, and bound it to the `NEW_WORKSPACE` hotkey with handler included in dependency array.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

Add dropdown create modal #391: Adds the NewWorkspaceModal component and useOpenNewWorkspaceModal hook that this PR utilizes for the hotkey binding.
ui(desktop): new button with shortcuts option #460: Wires the same NEW_WORKSPACE hotkey but defines the hotkey configuration entry and additional handlers in workspace UI components.
refactor (desktop): New workspace button #596: Adds alternative UI triggers (e.g., button clicks) to open the New Workspace modal using the same useOpenNewWorkspaceModal hook.

Suggested reviewers

CharlieHelps

Poem

🐰✨ A rabbit hops with glee,

NEW_WORKSPACE hotkey set free,

Bind the handler, wire it tight,

Opening modals at keyboard's might! 🚀

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description uses the correct template structure but lacks implementation details. Only the 'Bug fix' checkbox is marked; Description, Related Issues, Testing, and other sections remain empty.	Fill in the Description field to explain what the bug fix does. Add Related Issues if applicable. Provide Testing details to describe verification steps for the Cmd+N keyboard shortcut functionality.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: adding a keyboard shortcut (Cmd+N) to open a new workspace modal in the desktop application.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

apps/desktop/src/renderer/screens/main/index.tsx (1)
169-171: LGTM!

The hotkey binding correctly wires the NEW_WORKSPACE hotkey to open the modal, with proper dependency tracking. The implementation follows existing patterns in this file.
♻️ Optional: Simplify callback

The arrow function wrapper is unnecessary since openNewWorkspaceModal can be passed directly:
-useAppHotkey("NEW_WORKSPACE", () => openNewWorkspaceModal(), undefined, [
+useAppHotkey("NEW_WORKSPACE", openNewWorkspaceModal, undefined, [
   openNewWorkspaceModal,
 ]);
This is purely stylistic—the current implementation works correctly.

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 09b1687 and ea84e63.

📒 Files selected for processing (1)

apps/desktop/src/renderer/screens/main/index.tsx

🧰 Additional context used

📓 Path-based instructions (6)

apps/desktop/**/*.{ts,tsx}

📄 CodeRabbit inference engine (apps/desktop/AGENTS.md)

apps/desktop/**/*.{ts,tsx}: For Electron interprocess communication, ALWAYS use tRPC as defined in src/lib/trpc
Use alias as defined in tsconfig.json when possible
Prefer zustand for state management if it makes sense. Do not use effect unless absolutely necessary.
For tRPC subscriptions with trpc-electron, ALWAYS use the observable pattern from @trpc/server/observable instead of async generators, as the library explicitly checks isObservable(result) and throws an error otherwise

Files:

apps/desktop/src/renderer/screens/main/index.tsx

**/*.{ts,tsx}