Skip to content

fix (desktop): fix auth settings regression#832

Merged
AviPeltz merged 2 commits intomainfrom
fix-auth-thing-in-settings
Jan 19, 2026
Merged

fix (desktop): fix auth settings regression#832
AviPeltz merged 2 commits intomainfrom
fix-auth-thing-in-settings

Conversation

@AviPeltz
Copy link
Copy Markdown
Collaborator

@AviPeltz AviPeltz commented Jan 19, 2026

Description

Related Issues

Type of Change

  • Bug fix
  • New feature
  • Documentation
  • Refactor
  • Other (please describe):

Testing

Screenshots (if applicable)

Additional Notes

Summary by CodeRabbit

  • Chores
    • Internal module path adjustments to improve project organization and maintainability. No functional or user-facing behavior changes; existing account/settings workflows remain unchanged.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 19, 2026

📝 Walkthrough

Walkthrough

Updated the import path for authClient in the AccountSettings component from @superset/auth/client to renderer/lib/auth-client. No other functional or behavioral changes were made.

Changes

Cohort / File(s) Change Summary
Import Path Refactor
apps/desktop/src/renderer/routes/_authenticated/settings/account/components/AccountSettings/AccountSettings.tsx
Replaced import source for authClient from external package @superset/auth/client to internal module renderer/lib/auth-client

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • CharlieHelps

Poem

🐰 A hop, a switch, a tiny tweak,
The auth path found a local creek,
No fluster, fuss, or mighty shout,
Just smoother paths to roam about,
I nibble bugs and dance — hooray! 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description uses the correct template structure with the Type of Change marked as 'Bug fix', but all substantive sections are empty or contain only template comments. Fill in the Description section explaining the regression and fix, link related issues, and describe testing steps performed to verify the fix works.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix (desktop): fix auth settings regression' clearly describes the main change - fixing an auth settings regression in the desktop app.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@AviPeltz AviPeltz merged commit a0ba741 into main Jan 19, 2026
5 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ⚠️ Neon database branch
  • ⚠️ Electric Fly.io app

Thank you for your contribution! 🎉

@Kitenite Kitenite deleted the fix-auth-thing-in-settings branch January 19, 2026 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant