Skip to content

fix (desktop): auth cleint vs lib/auth-client#810

Merged
AviPeltz merged 2 commits intomainfrom
profile-fix
Jan 18, 2026
Merged

fix (desktop): auth cleint vs lib/auth-client#810
AviPeltz merged 2 commits intomainfrom
profile-fix

Conversation

@AviPeltz
Copy link
Copy Markdown
Collaborator

@AviPeltz AviPeltz commented Jan 18, 2026

Description

Related Issues

Type of Change

  • Bug fix
  • New feature
  • Documentation
  • Refactor
  • Other (please describe):

Testing

Screenshots (if applicable)

Additional Notes

Summary by CodeRabbit

Release Notes

  • Chores
    • Internal reference updated to streamline code organization. No user-facing changes or behavior differences.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 18, 2026

📝 Walkthrough

Walkthrough

Import source for authClient in the account settings page was changed from @superset/auth/client to renderer/lib/auth-client. No other code or behavioral changes were made.

Changes

Cohort / File(s) Summary
Import Path Update
apps/desktop/src/renderer/routes/_authenticated/settings/account/page.tsx
Replaced import source for authClient from @superset/auth/client to renderer/lib/auth-client (1 line changed).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • CharlieHelps

Poem

🐰 I hopped along the code-lined trail,
A tiny change, a shorter sail,
From distant crate to local nest,
The import found a cozy rest. ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description contains only the template structure with no substantive content filled in—sections are empty except for a single checkbox selection for 'Bug fix'. Critical sections like Description, Related Issues, and Testing lack any meaningful information. Fill in the Description section explaining the import path change, link any related issues, and describe testing steps performed to verify the fix.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title references an auth client import fix, which aligns with the actual change (import path update from '@superset/auth/client' to 'renderer/lib/auth-client'), though it contains a typo ('cleint' instead of 'client').
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@AviPeltz AviPeltz merged commit c4330d6 into main Jan 18, 2026
4 of 5 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ⚠️ Neon database branch
  • ⚠️ Electric Fly.io app

Thank you for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant