feat (desktop): added open first file on changes open by AviPeltz · Pull Request #693 · superset-sh/superset

AviPeltz · 2026-01-09T19:18:45Z

Description

Related Issues

Type of Change

Testing

Screenshots (if applicable)

Additional Notes

Summary by CodeRabbit

Release Notes

New Features
- Sidebar now automatically opens the first available changed file when activated
- Smart file selection prioritizes files by change status (staged, unstaged, untracked)
- File content automatically refreshes after opening from the sidebar
- Streamlined workflow for navigating recent changes in your workspace

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2026-01-09T19:18:52Z

📝 Walkthrough

Walkthrough

The SidebarControl component was enhanced to automatically open the first available changed file when the sidebar is activated. It queries workspace context, resolves the base branch, determines file changes by priority category (against-base, staged, unstaged, untracked), and integrates with tab management to display the file while invalidating cached content.

Changes

Cohort / File(s)	Summary
Sidebar Auto-File Opening `apps/desktop/src/renderer/screens/main/components/SidebarControl/SidebarControl.tsx`	Added priority-based file selection logic that activates when sidebar is toggled. Fetches workspace/worktree context, resolves base branch, queries file changes, integrates with tab management (addFileViewerPane, selectFile), and invalidates file content. Introduces handleClick handler replacing direct onClick behavior and adds FILE_CATEGORIES constant.

Sequence Diagrams

sequenceDiagram
    actor User
    participant SidebarControl
    participant WorkspaceStore
    participant FileChangesAPI
    participant TabManager
    participant FileContentCache

    User->>SidebarControl: Click toggle button
    SidebarControl->>SidebarControl: Check sidebar state
    alt Sidebar is closed
        SidebarControl->>WorkspaceStore: Fetch active workspace
        WorkspaceStore-->>SidebarControl: Return workspace/worktree context
        SidebarControl->>WorkspaceStore: Get base branch (with fallback)
        WorkspaceStore-->>SidebarControl: Return base branch
        SidebarControl->>FileChangesAPI: Query file changes by category
        FileChangesAPI-->>SidebarControl: Return prioritized file list
        SidebarControl->>SidebarControl: Select first available file
        SidebarControl->>TabManager: Add file to viewer pane
        TabManager-->>SidebarControl: File opened
        SidebarControl->>TabManager: Select file in tabs
        SidebarControl->>FileContentCache: Invalidate file content
        FileContentCache-->>SidebarControl: Cache cleared
    end
    SidebarControl->>SidebarControl: Toggle sidebar visibility
    SidebarControl-->>User: Sidebar toggled (+ file opened if closed)

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Poem

🐰 A button click now whispers "Come and see!"
Files opened first, by priority spree,
Workspace roots and branches dance in code,
Tab panes light up along the well-worn road,
The sidebar hops alive with eager glee! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	⚠️ Warning	The pull request description is entirely templated with no actual content filled in by the author.	Fill in all required sections: provide a clear description of changes, link related issues, specify the type of change, describe testing performed, and add any relevant screenshots or notes.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: adding functionality to open the first file when changes are opened, which aligns with the feature implementation.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

apps/desktop/src/renderer/screens/main/components/SidebarControl/SidebarControl.tsx (1)
107-114: Consider simplifying by extracting the common toggleSidebar() call.

Both branches call toggleSidebar(), which can be extracted to reduce duplication.
♻️ Suggested simplification
 const handleClick = useCallback(() => {
-	if (isSidebarOpen) {
-		toggleSidebar();
-	} else {
-		toggleSidebar();
+	const wasOpen = isSidebarOpen;
+	toggleSidebar();
+	if (!wasOpen) {
 		openFirstFile();
 	}
 }, [isSidebarOpen, toggleSidebar, openFirstFile]);

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3e43658 and a628a09.

📒 Files selected for processing (1)

apps/desktop/src/renderer/screens/main/components/SidebarControl/SidebarControl.tsx

🧰 Additional context used

📓 Path-based instructions (6)

apps/desktop/**/*.{ts,tsx}

📄 CodeRabbit inference engine (apps/desktop/AGENTS.md)

apps/desktop/**/*.{ts,tsx}: For Electron interprocess communication, ALWAYS use tRPC as defined in src/lib/trpc
Use alias as defined in tsconfig.json when possible
Prefer zustand for state management if it makes sense. Do not use effect unless absolutely necessary.
For tRPC subscriptions with trpc-electron, ALWAYS use the observable pattern from @trpc/server/observable instead of async generators, as the library explicitly checks isObservable(result) and throws an error otherwise

Files:

apps/desktop/src/renderer/screens/main/components/SidebarControl/SidebarControl.tsx

**/*.{ts,tsx}