feat(desktop): add file open mode setting (split pane vs new tab)#1369
Merged
Conversation
Add a new behavior setting that lets users choose how files open when no preview pane exists to reuse. Options are "Split pane" (default, existing behavior) and "New tab" (opens file in a dedicated tab).
Contributor
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughAdds a persisted file open mode setting (split-pane | new-tab), TRPC get/set procedures, UI control in Behavior settings, a renderer hook, propagation to file-opening components, a tabs store branch to create a new tab when requested, and a DB migration/schema update. Changes
Sequence DiagramsequenceDiagram
participant User as User
participant UI as BehaviorSettings UI
participant Hook as useFileOpenMode Hook
participant TRPC as Settings TRPC
participant DB as Database
participant FileUI as File-opening Components
participant Store as Tabs Store
User->>UI: Change file open mode
UI->>TRPC: setFileOpenMode(mode)
TRPC->>DB: UPDATE settings.file_open_mode
DB-->>TRPC: OK
TRPC-->>UI: success
User->>FileUI: Open file
FileUI->>Hook: useFileOpenMode()
Hook->>TRPC: getFileOpenMode()
TRPC->>DB: SELECT file_open_mode
DB-->>TRPC: mode
TRPC-->>Hook: mode or default
Hook-->>FileUI: mode
FileUI->>Store: addFileViewerPane({ openInNewTab: mode === "new-tab", ... })
alt openInNewTab true
Store->>Store: create new tab and pane, set active
Store-->>FileUI: pane id (new tab)
else
Store->>Store: reuse/create pane in current tab (split)
Store-->>FileUI: pane id (split)
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🚀 Preview Deployment🔗 Preview Links
Preview updates automatically with new commits |
This was referenced Mar 8, 2026
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Schema & Types (
packages/local-db)FILE_OPEN_MODESconst andFileOpenModetype inzod.tsfileOpenModecolumn to thesettingstable inschema.tsBackend (
apps/desktop)DEFAULT_FILE_OPEN_MODEconstant ("split-pane")getFileOpenModequery andsetFileOpenModemutation to the settings tRPC routerStore (
apps/desktop/src/renderer/stores/tabs)openInNewTab?: booleantoAddFileViewerPaneOptionsaddFileViewerPane, whenopenInNewTabis true and no preview pane exists, creates a new tab with the file viewer instead of splittingHook & Call Sites
useFileOpenModehook that reads the setting via tRPCFilesView,RightSidebar,SidebarControl,useFileLinkClickSettings UI
Test Plan
Summary by CodeRabbit