Skip to content

release(sdk): cut alpha.11 + drop internal warnings from public create result #4818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saddlepaddle merged 4 commits into from
May 21, 2026
Merged

release(sdk): cut alpha.11 + drop internal warnings from public create result #4818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ea3a4e1
release(sdk): cut alpha.11
saddlepaddle May 21, 2026
f740ff6
fix(workspaces): drop internal warnings from public create result
saddlepaddle May 21, 2026
ec27576
test(workspaces): drop warnings assertions from create-PR integration…
saddlepaddle May 21, 2026
b70b471
test(workspaces): assert PR head branch instead of removed warning
saddlepaddle May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 0 additions & 4 deletions packages/host-service/src/trpc/router/workspaces/workspaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,7 +574,6 @@ export const workspacesRouter = router({
let worktreePath: string;
let alreadyExists = false;
let workspaceRow: CloudWorkspace;
const warnings: string[] = [];

if (input.pr !== undefined) {
const releaseCreateLock = await acquireWorkspaceCreateLock(
Expand Down Expand Up @@ -614,7 +613,6 @@ export const workspacesRouter = router({
) => {
if (materialized.warning) {
console.warn(`[workspaces.create] ${materialized.warning}`);
warnings.push(materialized.warning);
}
};
const normalizeExistingPrBranch = async () => {
Expand Down Expand Up @@ -1015,7 +1013,6 @@ export const workspacesRouter = router({
});
if (warning) {
console.warn(`[workspaces.create] setup warning: ${warning}`);
warnings.push(warning);
}
if (terminal) {
terminalsResult.push({
Expand All @@ -1036,7 +1033,6 @@ export const workspacesRouter = router({
terminals: terminalsResult,
agents: agentsResult,
alreadyExists,
warnings,
txid: extractCreateTxid(workspaceRow),
};
}),
Expand Down
7 changes: 2 additions & 5 deletions packages/host-service/test/integration/workspace-create-pr.integration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,6 @@ describe("workspaces.create PR checkout integration", () => {
).toBe("HEAD:refs/heads/feature/pr-lockfile");
const dryRunOutput = await worktreeGit.raw(["push", "--dry-run"]);
expect(typeof dryRunOutput).toBe("string");
expect(result.warnings).toEqual([]);

const lockStatus = (
await worktreeGit.raw([
Expand Down Expand Up @@ -531,7 +530,6 @@ describe("workspaces.create PR checkout integration", () => {
expect(worktreePath).toBeTruthy();
if (!worktreePath) throw new Error("expected worktree path");
expect(result.workspace.branch).toBe("feature/same-repo");
expect(result.warnings).toEqual([]);
expect(
(
await scenario.repo.git.raw([
Expand All @@ -553,7 +551,7 @@ describe("workspaces.create PR checkout integration", () => {
).toBe(prHeadOid);
});

test("same-repo PR falls back to synthetic ref with a user-visible warning when the head branch is gone", async () => {
test("same-repo PR falls back to synthetic ref when the head branch is gone", async () => {
const prNumber = 8081;
let prHeadOid = "";

Expand Down Expand Up @@ -616,8 +614,7 @@ describe("workspaces.create PR checkout integration", () => {
)?.worktreePath;
expect(worktreePath).toBeTruthy();
if (!worktreePath) throw new Error("expected worktree path");
expect(result.warnings).toHaveLength(1);
expect(result.warnings[0]).toContain("was unavailable from origin");
expect(result.workspace.branch).toBe("feature/deleted-head");
expect(
(
await scenario.repo.git.raw([
Expand Down
1 change: 0 additions & 1 deletion packages/mcp-v2/src/tools/workspaces/create.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ export function register(server: McpServer): void {
| { ok: false; error: string }
>;
alreadyExists: boolean;
warnings: string[];
}>(
{
relayUrl: ctx.relayUrl,
Expand Down
2 changes: 1 addition & 1 deletion packages/sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@superset/sdk",
"version": "0.0.1-alpha.10",
"version": "0.0.1-alpha.11",
"description": "TypeScript SDK for the Superset API",
"private": true,
"type": "module",
Expand Down
1 change: 0 additions & 1 deletion packages/sdk/src/resources/workspaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,6 @@ export interface WorkspaceCreateResult {
terminals: Array<{ terminalId: string; label?: string }>;
agents: WorkspaceCreateAgentResult[];
alreadyExists: boolean;
warnings: string[];
}

export interface WorkspaceUpdateParams {
Expand Down
Loading