release(sdk): cut alpha.11 + drop internal warnings from public create result#4818
Conversation
|
Ready to review this PR? Stage has broken it down into 6 individual chapters for you: 
Chapters generated by Stage for commit b70b471 on May 21, 2026 10:36pm UTC. |
|
Capy auto-review is paused for this organization because the monthly auto-review limit has been reached. Increase the limit or turn it off in billing settings to resume automatic reviews. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughRemoved the aggregated ChangesWorkspace create + SDK updates
Sequence Diagram(s)(omitted — changes are primarily logging and response-shape adjustments; no new multi-component control flow requiring additional visualization) Possibly related PRs
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Greptile SummaryThis PR cuts the
Confidence Score: 3/5Safe to merge structurally, but the published package will continue to misreport its version to the server on every API call. The packages/sdk/src/version.ts needs to be updated to match the version in package.json before this is published.
|
| Filename | Overview |
|---|---|
| packages/sdk/package.json | Version bumped from 0.0.1-alpha.10 to 0.0.1-alpha.11; private: true + publishConfig pattern is consistent with prior alphas and the manual publish-from-dist workflow. |
| bun.lock | SDK lock entry updated to alpha.11; also catches up stale entries for apps/desktop (1.10.1→1.10.2) and packages/host-service (0.8.9→0.8.10) which were already at those versions in their package.json files. |
Sequence Diagram
sequenceDiagram
participant C as SDK Client
participant D as detect-platform.ts
participant V as version.ts
participant API as Superset API
C->>D: getDefaultHeaders()
D->>V: import VERSION
V-->>D: "0.0.1-alpha.7" (stale)
D-->>C: "{ X-Stainless-Package-Version: 0.0.1-alpha.7 }"
C->>API: HTTP request with stale version headers
Note over API: Sees alpha.7 instead of alpha.11
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
bun.lock:113-114
Lock file silently absorbs unrelated workspace version changes
The diff shows `apps/desktop` bumped from `1.10.1` → `1.10.2` and `packages/host-service` from `0.8.9` → `0.8.10` inside this release PR, even though only `packages/sdk/package.json` is mentioned in the checklist. Those packages' `package.json` files were already at the newer versions on `main` (the lock file was just stale). The changes are benign — `bun install` caught them up — but it means this PR silently carries lock-file churn for two unrelated packages. Worth confirming these bumps were intentional before merge. Were the `apps/desktop` (1.10.2) and `packages/host-service` (0.8.10) version entries in `bun.lock` picked up intentionally, or are they incidental drift from running `bun install`?
Reviews (1): Last reviewed commit: "release(sdk): cut alpha.11" | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| "name": "@superset/desktop", | ||
| "version": "1.10.1", | ||
| "version": "1.10.2", |
There was a problem hiding this comment.
The diff shows apps/desktop bumped from 1.10.1 → 1.10.2 and packages/host-service from 0.8.9 → 0.8.10 inside this release PR, even though only packages/sdk/package.json is mentioned in the checklist. Those packages' package.json files were already at the newer versions on main (the lock file was just stale). The changes are benign — bun install caught them up — but it means this PR silently carries lock-file churn for two unrelated packages. Worth confirming these bumps were intentional before merge. Were the apps/desktop (1.10.2) and packages/host-service (0.8.10) version entries in bun.lock picked up intentionally, or are they incidental drift from running bun install?
Prompt To Fix With AI
This is a comment left during a code review.
Path: bun.lock
Line: 113-114
Comment:
Lock file silently absorbs unrelated workspace version changes
The diff shows `apps/desktop` bumped from `1.10.1` → `1.10.2` and `packages/host-service` from `0.8.9` → `0.8.10` inside this release PR, even though only `packages/sdk/package.json` is mentioned in the checklist. Those packages' `package.json` files were already at the newer versions on `main` (the lock file was just stale). The changes are benign — `bun install` caught them up — but it means this PR silently carries lock-file churn for two unrelated packages. Worth confirming these bumps were intentional before merge. Were the `apps/desktop` (1.10.2) and `packages/host-service` (0.8.10) version entries in `bun.lock` picked up intentionally, or are they incidental drift from running `bun install`?
How can I resolve this? If you propose a fix, please make it concise.
🚀 Preview Deployment🔗 Preview Links
Preview updates automatically with new commits |
The workspace-create result's warnings[] was added post-alpha.10 (never published) and is consumed by nobody — desktop only reads cleanup/destroy warnings, and the create warnings are already console.warn'd server-side. Remove it from the host-service create return and the SDK / MCP type surfaces so CLI / SDK / MCP don't expose this internal detail.
saddlepaddle
changed the title
… test Follows the removal of warnings[] from the create result. The synthetic-ref fallback is still covered by the branch-merge-config and HEAD-OID assertions; the warning is now only console.warn'd, so the redundant warnings checks and the 'user-visible warning' wording are removed.
Keeps the create result asserted (result.workspace.branch) so the binding isn't an unused-variable lint warning after dropping the warnings checks.
1 participant
Cuts
@superset_sh/sdk0.0.1-alpha.11 and removes the internalwarnings[]field from the public workspace-create surface.Why
WorkspaceCreateResult.warningswas added after alpha.10 (#4643) and never published. Nothing consumes it:warningsfrom the destroy/cleanup flow, not create.data, so it leaked the field with no consumer.console.warn'd server-side, so removing the field loses no signal.CLI / SDK / MCP shouldn't carry this internal detail, so it's removed at the source.
Changes
workspaces.create: drop thewarnings[]array + return field (kept theconsole.warnlogging)WorkspaceCreateResult: removewarningsworkspaces/create: removewarningsfrom the result typepackages/sdk/package.json→0.0.1-alpha.11(+bun.lock)Verify
bun run build→ dist clean, nowarningsin emitted.d.tscd packages/sdk/dist && npm publish --access public(manual, after merge — needs npm auth)Left untouched: destroy/cleanup
warnings(separate feature, user-facing in desktop) and the internaladopt/CheckoutResulttypes (not part of the public surface).Summary by CodeRabbit
Version Updates
Changes
Tests