Skip to content

[codex] Update dashboard sidebar workspace icons#3755

Merged
Kitenite merged 1 commit intomainfrom
improve-sidebar-cloud-ico
Apr 26, 2026
Merged

[codex] Update dashboard sidebar workspace icons#3755
Kitenite merged 1 commit intomainfrom
improve-sidebar-cloud-ico

Conversation

@Kitenite
Copy link
Copy Markdown
Collaborator

@Kitenite Kitenite commented Apr 26, 2026

Summary

  • Replace the dashboard sidebar local workspace dot with the current icon glyph.
  • Replace cloud and offline-cloud workspace icons with Tabler cloud icons.
  • Keep existing PR-state and workspace-state icon priority intact.

Validation

  • bunx biome check apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspaceItem/components/DashboardSidebarWorkspaceIcon/DashboardSidebarWorkspaceIcon.tsx

Note: PR-state/data fixes are intentionally not included in this PR.


Summary by cubic

Updated dashboard sidebar workspace icons for clearer, consistent visuals. Local workspaces now use RxDot, and remote workspaces use Tabler TbCloud/TbCloudOff; existing PR/workspace icon priority remains unchanged.

  • Refactors
    • Replaced LuCloud/LuCloudOff with TbCloud/TbCloudOff.
    • Swapped custom span dot for RxDot and unified size/color classes.
    • No PR-state or workspace-state logic changes.

Written for commit d2be1e8. Summary will update on new commits.

Summary by CodeRabbit

  • Style
    • Updated cloud and local storage status icons in the dashboard workspace panel for improved visual consistency and better design alignment with the rest of the application.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 26, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e11ed057-c2b1-4665-95ce-b2f8e0c2b951

📥 Commits

Reviewing files that changed from the base of the PR and between 25b2d52 and d2be1e8.

📒 Files selected for processing (1)
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspaceItem/components/DashboardSidebarWorkspaceIcon/DashboardSidebarWorkspaceIcon.tsx

📝 Walkthrough

Walkthrough

A workspace icon component is updated to swap icon libraries: Lucide cloud icons are replaced with Tabler cloud icons, and a custom dot indicator is replaced with the Radix icon library's dot component. Styling and color application behavior remain unchanged.

Changes

Cohort / File(s) Summary
Workspace Icon Component
apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspaceItem/components/DashboardSidebarWorkspaceIcon/DashboardSidebarWorkspaceIcon.tsx
Icon library migration: replaces LuCloud/LuCloudOff with TbCloud/TbCloudOff for cloud status display; replaces custom span-based local device indicator with RxDot icon. Styling behavior and opacity logic for offline state preserved.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

☁️ ✨ A dash of Tabler brings the clouds anew,
The local dot shines bright—Radix's debut,
Same style, same flow, just icons refreshed,
The workspace display is freshly dressed! 🐰

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch improve-sidebar-cloud-ico

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Kitenite Kitenite marked this pull request as ready for review April 26, 2026 06:12
@Kitenite Kitenite merged commit a4079e7 into main Apr 26, 2026
5 of 6 checks passed
@Kitenite Kitenite deleted the improve-sidebar-cloud-ico branch April 26, 2026 06:12
@github-actions
Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ⚠️ Neon database branch

Thank you for your contribution! 🎉

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Apr 26, 2026

Greptile Summary

This PR replaces the dashboard sidebar workspace icons: the local-device dot (previously a custom <span> with a background color) is swapped for RxDot, and the remote cloud icons are updated from Lucide (LuCloud/LuCloudOff) to Tabler (TbCloud/TbCloudOff). No PR-state or workspace-state priority logic is changed.

Confidence Score: 5/5

Safe to merge — purely a visual icon swap with no logic changes.

The change is limited to swapping icon components with correct color-class updates. No logic, priority, or state handling is altered. No P0/P1 findings.

No files require special attention.

Important Files Changed

Filename Overview
apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspaceItem/components/DashboardSidebarWorkspaceIcon/DashboardSidebarWorkspaceIcon.tsx Icon swap: LuCloud/LuCloudOffTbCloud/TbCloudOff, and custom <span> dot → RxDot; no logic changes, color handling correctly updated from background classes to text classes.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[renderPrimaryIcon] --> B{pullRequestState?}
    B -- yes --> C[PR Icon\nLuGitPullRequest / LuGitMerge\nLuGitPullRequestClosed / LuGitPullRequestDraft]
    B -- no --> D{hostType === local-device?}
    D -- yes --> E[RxDot\nsize-4, iconColor]
    D -- no --> F{isRemoteDeviceOffline?}
    F -- yes --> G[TbCloudOff\nsize-4, iconColor, opacity-60]
    F -- no --> H[TbCloud\nsize-4, iconColor]
Loading

Reviews (1): Last reviewed commit: "Update dashboard sidebar workspace icons" | Re-trigger Greptile

MocA-Love added a commit to MocA-Love/superset that referenced this pull request Apr 26, 2026
3 PR (#442, #443, #444) で取り込み済みの 9 commits を git 履歴上もマージ済みに記録する。
内容差分は無し (merge -s ours)。

取り込み内容:
- 6b96acd Improve sidebar group management UX (superset-sh#3745)
- a4079e7 Update dashboard sidebar workspace icons (superset-sh#3755)
- d3753d0 [codex] Use dynamic footer copyright years (superset-sh#3754)
- ce606be Handle browser passthrough during v2 resize (superset-sh#3744)
- b1e1eb7 Refactor v2 workspace page (superset-sh#3747)
- 8693869 [codex] move v2 toggle to experimental settings (superset-sh#3748)
- ef3f381 Revert "fix(desktop): refit v2 terminal after font settle (superset-sh#3742)" (superset-sh#3750) - 手動移植 (vibrancy patch 維持)
- 25b2d52 Show terminal sessions from all workspaces in dropdown (superset-sh#3751)
- 62737db fix v1 terminal resize repaint (superset-sh#3756)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant