Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughFooter components were changed to compute and render the current year at runtime (using Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 Preview Deployment🔗 Preview Links
Preview updates automatically with new commits |
Greptile SummaryUpdates the hardcoded copyright year in Confidence Score: 5/5Safe to merge — minimal single-line change with no functional risk. Only finding is a P2 style suggestion to use a dynamic year expression; no correctness or reliability concerns. No files require special attention.
|
| Filename | Overview |
|---|---|
| apps/web/src/app/(dashboard-legacy)/components/Footer/Footer.tsx | Single-line change updating hardcoded copyright year from 2025 to 2026; correct but still hardcoded (dynamic year would avoid future manual updates) |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Footer.tsx renders] --> B["© 2026 Superset (hardcoded)"]
B --> C[Displayed in legacy dashboard footer]
style B fill:#f9f,stroke:#333
Prompt To Fix All With AI
This is a comment left during a code review.
Path: apps/web/src/app/(dashboard-legacy)/components/Footer/Footer.tsx
Line: 7
Comment:
**Hardcoded year will need another manual update next year**
The copyright year is still a static string, meaning this same patch will be needed again next year. Using `new Date().getFullYear()` keeps the footer perpetually accurate without future manual changes:
```suggestion
<p className="text-sm text-muted-foreground">© {new Date().getFullYear()} Superset</p>
```
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "Update web footer year" | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| <footer className="mt-auto w-full border-t border-border/50 py-5"> | ||
| <div className="mx-auto flex w-[95vw] max-w-screen-2xl items-center justify-between"> | ||
| <p className="text-sm text-muted-foreground">© 2025 Superset</p> | ||
| <p className="text-sm text-muted-foreground">© 2026 Superset</p> |
There was a problem hiding this comment.
The copyright year is still a static string, meaning this same patch will be needed again next year. Using new Date().getFullYear() keeps the footer perpetually accurate without future manual changes:
| <p className="text-sm text-muted-foreground">© 2026 Superset</p> | |
| <p className="text-sm text-muted-foreground">© {new Date().getFullYear()} Superset</p> |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/web/src/app/(dashboard-legacy)/components/Footer/Footer.tsx
Line: 7
Comment:
**Hardcoded year will need another manual update next year**
The copyright year is still a static string, meaning this same patch will be needed again next year. Using `new Date().getFullYear()` keeps the footer perpetually accurate without future manual changes:
```suggestion
<p className="text-sm text-muted-foreground">© {new Date().getFullYear()} Superset</p>
```
How can I resolve this? If you propose a fix, please make it concise.![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
saddlepaddle
changed the title
3 PR (#442, #443, #444) で取り込み済みの 9 commits を git 履歴上もマージ済みに記録する。 内容差分は無し (merge -s ours)。 取り込み内容: - 6b96acd Improve sidebar group management UX (superset-sh#3745) - a4079e7 Update dashboard sidebar workspace icons (superset-sh#3755) - d3753d0 [codex] Use dynamic footer copyright years (superset-sh#3754) - ce606be Handle browser passthrough during v2 resize (superset-sh#3744) - b1e1eb7 Refactor v2 workspace page (superset-sh#3747) - 8693869 [codex] move v2 toggle to experimental settings (superset-sh#3748) - ef3f381 Revert "fix(desktop): refit v2 terminal after font settle (superset-sh#3742)" (superset-sh#3750) - 手動移植 (vibrancy patch 維持) - 25b2d52 Show terminal sessions from all workspaces in dropdown (superset-sh#3751) - 62737db fix v1 terminal resize repaint (superset-sh#3756)
2 participants
Summary
new Date().getFullYear().new Date().getFullYear().Root Cause
The legacy web footer used a static year string, which would require another manual update when the year changes. The shared email footer had the same rolling-year issue.
Impact
Website and email footer copyright years now stay current without annual manual patches.
Validation
bunx @biomejs/biome@2.4.2 check 'apps/web/src/app/(dashboard-legacy)/components/Footer/Footer.tsx' packages/email/src/components/layout/StandardLayout/components/Footer/Footer.tsx© 20xxstrings.Summary by CodeRabbit