Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,12 @@ export function WorkspaceInitializingView({
<h2 className="text-lg font-medium text-foreground">
Setup incomplete
</h2>
<p className="text-sm text-muted-foreground">{workspaceName}</p>
<p
className="line-clamp-3 max-w-full break-words text-sm text-muted-foreground [overflow-wrap:anywhere]"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 break-words is redundant alongside [overflow-wrap:anywhere]

Tailwind's break-words sets overflow-wrap: break-word, which is immediately overridden by the [overflow-wrap:anywhere] arbitrary value. The anywhere keyword is strictly more aggressive and already handles all the cases break-word covers, so break-words has no additional effect. The same redundancy exists on line 220.

Suggested change
className="line-clamp-3 max-w-full break-words text-sm text-muted-foreground [overflow-wrap:anywhere]"
className="line-clamp-3 max-w-full text-sm text-muted-foreground [overflow-wrap:anywhere]"
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/desktop/src/renderer/screens/main/components/WorkspaceView/WorkspaceInitializingView/WorkspaceInitializingView.tsx
Line: 124

Comment:
**`break-words` is redundant alongside `[overflow-wrap:anywhere]`**

Tailwind's `break-words` sets `overflow-wrap: break-word`, which is immediately overridden by the `[overflow-wrap:anywhere]` arbitrary value. The `anywhere` keyword is strictly more aggressive and already handles all the cases `break-word` covers, so `break-words` has no additional effect. The same redundancy exists on line 220.

```suggestion
className="line-clamp-3 max-w-full text-sm text-muted-foreground [overflow-wrap:anywhere]"
```

How can I resolve this? If you propose a fix, please make it concise.

title={workspaceName}
>
{workspaceName}
</p>
<p className="text-xs text-muted-foreground/80 mt-2">
Workspace setup didn't finish. You can retry or remove it.
</p>
Expand Down Expand Up @@ -211,7 +216,12 @@ export function WorkspaceInitializingView({
<h2 className="text-lg font-medium text-foreground">
Workspace setup failed
</h2>
<p className="text-sm text-muted-foreground">{workspaceName}</p>
<p
className="line-clamp-3 max-w-full break-words text-sm text-muted-foreground [overflow-wrap:anywhere]"
title={workspaceName}
>
{workspaceName}
</p>
{progress?.error && (
<p className="text-xs text-destructive/80 mt-2 bg-destructive/5 rounded-md px-3 py-2 select-text cursor-text break-words">
{progress.error}
Expand Down
Loading