Fix long workspace titles on creation error page#3718
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated the WorkspaceInitializingView component to improve display of workspace names in error and interrupt states by adding line clamping, text wrapping, and a hover tooltip attribute for better usability when names exceed available space. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR fixes long workspace names overflowing the error UI by applying Confidence Score: 5/5Safe to merge — changes are purely presentational with no logic or data-flow impact. All findings are P2 style suggestions (redundant CSS class, and the same fix not applied to the initializing state). No correctness or data-integrity issues exist. No files require special attention.
|
| Filename | Overview |
|---|---|
| apps/desktop/src/renderer/screens/main/components/WorkspaceView/WorkspaceInitializingView/WorkspaceInitializingView.tsx | Adds line-clamp-3, break-words, and [overflow-wrap:anywhere] with a native title tooltip to the workspace name paragraph in both the "Setup incomplete" and "Setup failed" error states, preventing long names from overflowing the layout. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[WorkspaceInitializingView] --> B{isInterrupted && !progress && showInterruptedUI?}
B -- Yes --> C["Setup incomplete state\n(now: line-clamp-3 + title tooltip)"]
B -- No --> D{hasFailed?}
D -- Yes --> E["Setup failed state\n(now: line-clamp-3 + title tooltip)"]
D -- No --> F["Initializing state\n(workspaceName — no clamp applied)"]
C --> G["Delete / Retry buttons"]
E --> H["Delete / Retry buttons"]
Comments Outside Diff (1)
-
apps/desktop/src/renderer/screens/main/components/WorkspaceView/WorkspaceInitializingView/WorkspaceInitializingView.tsx, line 326 (link)Long workspace name can still overflow in the initializing state
The "Setting up workspace" paragraph at this line doesn't apply the same
line-clamp/[overflow-wrap:anywhere]treatment added to the two error states. A workspace with a very long name would still overflow themax-w-mdcontainer here. Consider making the fix consistent across all three states.Prompt To Fix With AI
This is a comment left during a code review. Path: apps/desktop/src/renderer/screens/main/components/WorkspaceView/WorkspaceInitializingView/WorkspaceInitializingView.tsx Line: 326 Comment: **Long workspace name can still overflow in the initializing state** The "Setting up workspace" paragraph at this line doesn't apply the same `line-clamp` / `[overflow-wrap:anywhere]` treatment added to the two error states. A workspace with a very long name would still overflow the `max-w-md` container here. Consider making the fix consistent across all three states. How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix All With AI
This is a comment left during a code review.
Path: apps/desktop/src/renderer/screens/main/components/WorkspaceView/WorkspaceInitializingView/WorkspaceInitializingView.tsx
Line: 124
Comment:
**`break-words` is redundant alongside `[overflow-wrap:anywhere]`**
Tailwind's `break-words` sets `overflow-wrap: break-word`, which is immediately overridden by the `[overflow-wrap:anywhere]` arbitrary value. The `anywhere` keyword is strictly more aggressive and already handles all the cases `break-word` covers, so `break-words` has no additional effect. The same redundancy exists on line 220.
```suggestion
className="line-clamp-3 max-w-full text-sm text-muted-foreground [overflow-wrap:anywhere]"
```
How can I resolve this? If you propose a fix, please make it concise.
---
This is a comment left during a code review.
Path: apps/desktop/src/renderer/screens/main/components/WorkspaceView/WorkspaceInitializingView/WorkspaceInitializingView.tsx
Line: 326
Comment:
**Long workspace name can still overflow in the initializing state**
The "Setting up workspace" paragraph at this line doesn't apply the same `line-clamp` / `[overflow-wrap:anywhere]` treatment added to the two error states. A workspace with a very long name would still overflow the `max-w-md` container here. Consider making the fix consistent across all three states.
```suggestion
<p className="line-clamp-3 max-w-full text-sm text-muted-foreground [overflow-wrap:anywhere]" title={workspaceName}>{workspaceName}</p>
```
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "fix desktop workspace creation title cla..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| </h2> | ||
| <p className="text-sm text-muted-foreground">{workspaceName}</p> | ||
| <p | ||
| className="line-clamp-3 max-w-full break-words text-sm text-muted-foreground [overflow-wrap:anywhere]" |
There was a problem hiding this comment.
break-words is redundant alongside [overflow-wrap:anywhere]
Tailwind's break-words sets overflow-wrap: break-word, which is immediately overridden by the [overflow-wrap:anywhere] arbitrary value. The anywhere keyword is strictly more aggressive and already handles all the cases break-word covers, so break-words has no additional effect. The same redundancy exists on line 220.
| className="line-clamp-3 max-w-full break-words text-sm text-muted-foreground [overflow-wrap:anywhere]" | |
| className="line-clamp-3 max-w-full text-sm text-muted-foreground [overflow-wrap:anywhere]" |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/desktop/src/renderer/screens/main/components/WorkspaceView/WorkspaceInitializingView/WorkspaceInitializingView.tsx
Line: 124
Comment:
**`break-words` is redundant alongside `[overflow-wrap:anywhere]`**
Tailwind's `break-words` sets `overflow-wrap: break-word`, which is immediately overridden by the `[overflow-wrap:anywhere]` arbitrary value. The `anywhere` keyword is strictly more aggressive and already handles all the cases `break-word` covers, so `break-words` has no additional effect. The same redundancy exists on line 220.
```suggestion
className="line-clamp-3 max-w-full text-sm text-muted-foreground [overflow-wrap:anywhere]"
```
How can I resolve this? If you propose a fix, please make it concise.
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
upstream の 10 commits は #426 と #427 で fork 固有の差分を保ちながら個別に cherry-pick 取り込み済み。本 merge は ours strategy で **記録だけ** マージ済みに することで behind=0 を達成し、git 履歴上の追跡を正しくする。 Cherry-pick 取り込み済 (PR #426): - 5aab22a fix closed picker filters (superset-sh#3702) → cdb52f9 - 99db5be [codex] simplify workspace controls (superset-sh#3714) → f079606 - 186078a fix(chat): prevent ask_user question from shadowing sandbox access prompt (superset-sh#3662) → 09d6b57 - 47893c2 fix desktop workspace creation title clamp (superset-sh#3718) → 6a8c4ae - 09323ff Add diff pane file viewer action (superset-sh#3715) → 817ed8d - a5891c6 remove pending launch log (superset-sh#3721) → 0764d03 - c83de0c Add Tiptap table support (superset-sh#3719) → e67a885 - 486b621 [codex] Fix v2 terminal lifecycle after sleep (superset-sh#3711) → b71fbbb (+ #426 内 review fixups) Cherry-pick 取り込み済 (PR #427): - e07aef6 feat(desktop): play v2 notification hooks client-side (superset-sh#3675) → 27ac18a - eae6008 [codex] Port v2 terminal hotkeys to v1 (superset-sh#3724) → 05a77b8 (+ #427 内 Windows .ps1 v2 化) Fork 固有領域は変更ゼロで保持: 19 tRPC procedures (workspaces.githubExtended)、 AudioScheduler / Aivis TTS / notification-manager、terminal suggestion handler (新 terminalKeyboardHandler.ts に移植)、TERMINAL_OPTIONS、SUPERSET_WORKSPACE_NAME、 MainWindowEffects、INCEPTION_AUTH_PROVIDER_ID、v1MigrationState、TiptapPromptEditor、 electron-builder.ts (dmg.size="4g", fileAssociations)、Service Status Dashboard、 Linux daemon systemd、Worktree auto-sync、Windows support、DnD scratch route 他。
1 participant
Summary
Fixes SUPER-440
Verification
Summary by cubic
Fixes overflow from long workspace names on the "Setup incomplete" and "Workspace setup failed" views by clamping to 3 lines and breaking long words. The full name is still shown on hover via the title tooltip. Addresses SUPER-440.
Written for commit e7ee21a. Summary will update on new commits.
Summary by CodeRabbit
Bug Fixes
Style