fix(desktop): make v2 right sidebar toggle reactive

[saddlepaddle]

Summary

• The v2 right sidebar toggle's hover icon swap (LuPanelRight → LuPanelRightOpen/LuPanelRightClose) was silently broken: isOpen was read via a one-shot collections.v2WorkspaceLocalState.get(workspaceId) call, so the component never re-rendered when rightSidebarOpen changed.
• Switched to useLiveQuery (matching useV2WorkspacePaneLayout) so the toggle reactively reflects the current state, and the hover icon now matches the left sidebar toggle's behavior.

Test plan

• Open a v2 workspace, confirm right sidebar toggle icon swaps on hover when sidebar is closed (shows open-arrow) vs open (shows close-arrow)
• Toggle via hotkey (⌘L) and confirm the top-bar icon updates without needing a remount

---

Summary by cubic

Make the v2 right sidebar toggle reactive so the hover icon reflects the current open state. Replaced a one-off state read with a live query tied to v2WorkspaceLocalState.

• Bug Fixes
  • Switched to useLiveQuery from @tanstack/react-db with eq from @tanstack/db to subscribe to per-workspace v2WorkspaceLocalState.
  • Hover icon now correctly shows open/close state and updates on hotkey toggle (⌘L), matching the left sidebar behavior.

^{Written for commit 94efc23. Summary will update on new commits.}

Summary by CodeRabbit

• Bug Fixes
  • The right sidebar open/closed state now updates in real-time as database state changes, replacing previous locally-cached state handling to ensure consistent sidebar behavior throughout the application.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7f5a1f85-c649-403a-8ccc-380296e5d2ed

📥 Commits

Reviewing files that changed from the base of the PR and between 039edf2 and 94efc23.

📒 Files selected for processing (1)

• apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/TopBar/components/RightSidebarToggle/RightSidebarToggle.tsx

---

📝 Walkthrough

Walkthrough

Replaced synchronous local state lookup in the RightSidebarToggle component with a reactive useLiveQuery database query. The sidebar state is now derived from live database rows filtered by workspace ID rather than being accessed from an in-memory cache, enabling real-time updates.

Changes

Cohort / File(s)	Summary
RightSidebarToggle State Management apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/TopBar/components/RightSidebarToggle/RightSidebarToggle.tsx	Migrated from synchronous collections.v2WorkspaceLocalState.get(workspaceId) to reactive useLiveQuery with workspaceId filtering; isOpen now derived from first matching database row with fallback to false.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 From sync to live, the state takes flight,
No more stale data holding tight,
The query dances, fresh and free,
Sidebar opens reactively! ✨
Real-time magic, oh what a sight!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: making the v2 right sidebar toggle reactive.
Description check	✅ Passed	The description includes a detailed summary, test plan, and context but is missing some template sections like Related Issues and Type of Change selection.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch left-sidebar-icon

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[greptile-apps]

Greptile Summary

This PR fixes a reactivity bug in the RightSidebarToggle component where isOpen was read via a one-shot collections.v2WorkspaceLocalState.get(workspaceId) call, so the component never re-rendered when rightSidebarOpen changed externally (e.g., via the ⌘L hotkey). The fix switches to useLiveQuery, which subscribes to changes and triggers re-renders correctly.

• Replaced one-shot .get(workspaceId) with useLiveQuery matching the exact pattern used in useV2WorkspacePaneLayout.ts
• Added eq from @tanstack/db and useLiveQuery from @tanstack/react-db — the same imports already used by the neighbouring hook
• The localStateRows[0]?.rightSidebarOpen ?? false default preserves the existing fallback behavior

Confidence Score: 5/5

Safe to merge — the change is a one-file, targeted bug fix that adopts the codebase's established reactive pattern.

The fix is minimal and correct: it replaces a non-reactive read with useLiveQuery using the exact same query shape, imports, and dependency array already proven in useV2WorkspacePaneLayout.ts. The fallback default ?? false is preserved, and the rest of the component (toggle action, icon logic, tooltip) is unchanged. No new patterns are introduced and no regressions are expected.

No files require special attention.

Important Files Changed

Filename	Overview
apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/TopBar/components/RightSidebarToggle/RightSidebarToggle.tsx	Replaces one-shot .get() with useLiveQuery so isOpen reactively updates; directly mirrors the established pattern in useV2WorkspacePaneLayout.ts.

Sequence Diagram

sequenceDiagram
    participant Hotkey as ⌘L Hotkey
    participant Toggle as RightSidebarToggle
    participant Collection as v2WorkspaceLocalState
    participant LiveQuery as useLiveQuery

    Note over Toggle,LiveQuery: Before fix — one-shot read
    Toggle->>Collection: .get(workspaceId)
    Collection-->>Toggle: snapshot (stale, no re-render on change)
    Hotkey->>Collection: .update(workspaceId, draft)
    Note over Toggle: Toggle never re-renders — icon stays stale

    Note over Toggle,LiveQuery: After fix — reactive subscription
    LiveQuery->>Collection: subscribe query (workspaceId)
    Collection-->>Toggle: live rows (triggers re-render on any change)
    Hotkey->>Collection: .update(workspaceId, draft)
    Collection-->>LiveQuery: row changed
    LiveQuery-->>Toggle: re-render with updated isOpen

Loading

_{Reviews (1): Last reviewed commit: "fix(desktop): make v2 right sidebar togg..." | Re-trigger Greptile}

[github-actions]

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

• ✅ Neon database branch
• ⚠️ Electric Fly.io app

Thank you for your contribution! 🎉

[cubic-dev-ai]

No issues found across 1 file