feat(desktop): v2 diff viewer opens in its own tab + collapsed tab/pane title resolution#3420
Merged
Conversation
… titles openDiffPane now scans all tabs for an existing diff pane (focus + scroll) and falls back to addTab, so clicking a file in the Changes sidebar never hijacks the focused editor tab. Collapses tab/pane title resolution onto a single canonical field: PaneDefinition.getTitle is tightened to (pane) => string, file's rich JSX moves into the existing renderTitle hook, and a new resolveTabTitle helper powers both the tab bar and the "Move to Tab" context menu. tab.titleOverride is reserved for user renames; every auto-default caller is stripped and multi-pane tabs fall back to "Tab N" instead of "tab-<uuid>".
…user renames Preset execution and workspace bootstrap were baking preset.name / terminal.label onto tab.titleOverride, which meant those names persisted misleadingly after a tab was split and couldn't be distinguished from a real user rename. Move both to the pane's titleOverride instead, and teach resolveTabTitle to read pane.titleOverride before falling through to getTitle() for single-pane tabs. tab.titleOverride is now written only by the tab-bar rename action; splitting a named tab flips the label to "Tab N" while the pane keeps its name in its header, and user renames still win over everything.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughMoved per-tab title overrides into individual pane objects, introduced a centralized resolveTabTitle utility, changed PaneDefinition.getTitle to accept a pane, removed Workspace-level getTabTitle prop, and updated callers/tests/store to use pane-level title resolution. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Page as Page
participant Hook as useDefaultContextMenuActions
participant Registry as PaneRegistry
participant Workspace as Workspace/TabBar
Page->>Hook: call useDefaultContextMenuActions(paneRegistry)
Hook->>Registry: request resolveTabTitle(tab, tabs, paneRegistry)
Registry->>Workspace: ask pane definition getTitle(pane)
Workspace-->>Registry: returns derived title or undefined
Registry-->>Hook: returns final tab label
Hook-->>Page: context-menu items with resolved labels
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR delivers three related improvements to the v2 desktop workspace: (1) diff pane viewer opens in its own dedicated tab rather than hijacking the active editor; (2) tab/pane title resolution is unified through a single Key changes:
Confidence Score: 4/5Safe to merge after fixing the one-line browser getTitle fallback to prevent UUID appearing as pane header. The architecture is well-thought-out: resolveTabTitle cleanly unifies two divergent title-resolution paths, the getTitle/renderTitle separation is correct for all panes, the openDiffPane tab-search is correct, and all 71 package tests pass. The single concrete regression — browser.getTitle returning undefined for about:blank causes the pane header to fall back to pane.id (a UUID) — is a targeted one-line fix and does not affect the primary diff-viewer or title-resolution flows. usePaneRegistry.tsx: browser.getTitle missing "Browser" fallback; resolveTabTitle.ts: indexOf edge case with Tab 0. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["resolveTabTitle(tab, tabs, registry)"] --> B{tab.titleOverride?}
B -- yes --> Z["return titleOverride (user rename wins)"]
B -- no --> C{single pane?}
C -- no --> D["return 'Tab N' (LTR index)"]
C -- yes --> E{pane.titleOverride?}
E -- yes --> F["return pane.titleOverride"]
E -- no --> G["registry[kind].getTitle(pane)"]
G -- string --> H["return string"]
G -- undefined --> D
subgraph TabBar["Tab Bar (Workspace.tsx)"]
T1["getTabTitle = resolveTabTitle(tab, tabs, registry)"]
end
subgraph ContextMenu["Move to Tab Menu (useDefaultContextMenuActions)"]
T2["label = resolveTabTitle(tab, tabs, paneRegistry)"]
end
subgraph PaneHeader["Pane Header (Pane.tsx)"]
T3["title = pane.titleOverride ?? registry[kind].getTitle(pane) ?? pane.id"]
T4["titleContent = registry[kind].renderTitle(ctx)"]
end
A --> TabBar
A --> ContextMenu
Reviews (1): Last reviewed commit: "feat(desktop): pane-derived tab titles r..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
264
to
275
| browser: { | ||
| getIcon: () => <Globe className="size-4" />, | ||
| getTitle: (ctx: RendererContext<PaneViewerData>) => { | ||
| const data = ctx.pane.data as BrowserPaneData; | ||
| return data.pageTitle || data.url; | ||
| getTitle: (pane) => { | ||
| const data = pane.data as BrowserPaneData; | ||
| if (data.pageTitle) return data.pageTitle; | ||
| if (data.url && data.url !== "about:blank") { | ||
| try { | ||
| return new URL(data.url).hostname; | ||
| } catch {} | ||
| } | ||
| return undefined; | ||
| }, |
There was a problem hiding this comment.
browser.getTitle now returns undefined when the URL is "about:blank" and there's no pageTitle. Pane.tsx resolves the header title via:
pane.titleOverride ?? definition.getTitle?.(pane) ?? pane.idWhen getTitle returns undefined and titleOverride is unset (which is the case for a freshly-opened browser tab), the pane header displays the raw pane UUID (e.g. "pane-abc123..."). Before this PR, browser.getTitle fell back to data.url (so at least "about:blank" appeared), and addBrowserTab set titleOverride: "Browser". Both safety nets are now gone.
Add a "Browser" fallback so unnavigated browser panes show a human-readable header title:
Suggested change
| browser: { | |
| getIcon: () => <Globe className="size-4" />, | |
| getTitle: (ctx: RendererContext<PaneViewerData>) => { | |
| const data = ctx.pane.data as BrowserPaneData; | |
| return data.pageTitle || data.url; | |
| getTitle: (pane) => { | |
| const data = pane.data as BrowserPaneData; | |
| if (data.pageTitle) return data.pageTitle; | |
| if (data.url && data.url !== "about:blank") { | |
| try { | |
| return new URL(data.url).hostname; | |
| } catch {} | |
| } | |
| return undefined; | |
| }, | |
| getTitle: (pane) => { | |
| const data = pane.data as BrowserPaneData; | |
| if (data.pageTitle) return data.pageTitle; | |
| if (data.url && data.url !== "about:blank") { | |
| try { | |
| return new URL(data.url).hostname; | |
| } catch {} | |
| } | |
| return "Browser"; | |
| }, |
| onlyPane.titleOverride ?? registry[onlyPane.kind]?.getTitle?.(onlyPane); | ||
| if (fromPane) return fromPane; | ||
| } | ||
| return `Tab ${tabs.indexOf(tab) + 1}`; |
There was a problem hiding this comment.
tab is not found in tabs
tabs.indexOf(tab) relies on reference equality. If tab ever arrives from a different snapshot than tabs (e.g. a stale closure in an async context), indexOf returns -1 and the label becomes "Tab 0". All current callers pass tab as an element from the same tabs array so this is low-risk today, but the fallback is fragile.
A defensive guard makes the intent explicit and prevents a confusing "Tab 0" label:
Suggested change
| return `Tab ${tabs.indexOf(tab) + 1}`; | |
| return `Tab ${tabs.indexOf(tab) + 1 || tabs.length}`; |
Or add a comment documenting the invariant so future callers know tab must be a member of tabs.
Contributor
🚀 Preview Deployment🔗 Preview Links
Preview updates automatically with new commits |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/page.tsx (1)
143-159:⚠️ Potential issue | 🟠 MajorPrefer the active tab's diff pane before the global scan.
Line 146 starts with every tab in order, so a background diff tab can win before a split diff pane in the active tab. In that case, clicking the Changes sidebar jumps the user away from the current layout instead of reusing the split-out pane this flow is supposed to preserve.
💡 Suggested fix
const openDiffPane = useCallback( (filePath: string) => { const state = store.getState(); - for (const tab of state.tabs) { + const activeTab = state.tabs.find((tab) => tab.id === state.activeTabId); + const tabSearchOrder = activeTab + ? [activeTab, ...state.tabs.filter((tab) => tab.id !== activeTab.id)] + : state.tabs; + + for (const tab of tabSearchOrder) { for (const pane of Object.values(tab.panes)) { if (pane.kind !== "diff") continue;🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/`$workspaceId/page.tsx around lines 143 - 159, The current openDiffPane callback scans every tab in order so a background diff pane can be chosen before a diff pane in the currently active tab; update openDiffPane (which uses store.getState(), state.tabs, pane.kind and calls state.setPaneData, state.setActiveTab and state.setActivePane) to first look for a diff pane inside the active tab (use state.activeTab or activeTabId from state) and reuse that pane if found, and only if not found fall back to scanning all other tabs for a diff pane; ensure the same setPaneData/setActiveTab/setActivePane flow is applied when reusing the active-tab pane.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/`$workspaceId/hooks/usePaneRegistry/usePaneRegistry.tsx:
- Around line 266-275: The fallback title generator in getTitle for
BrowserPaneData currently uses new URL(data.url).hostname which drops port
numbers (e.g., localhost:3000 -> localhost); update that expression to use new
URL(data.url).host so the returned fallback includes the port when present,
keeping the surrounding try/catch and existing conditions intact.
In `@packages/panes/src/react/components/Workspace/utils/resolveTabTitle.ts`:
- Line 17: The fallback uses tabs.indexOf(tab) which can return -1 for
equivalent but non-identical tab objects; update resolveTabTitle to compute
index with a robust lookup (e.g., use tabs.findIndex(t => t.id === tab.id ||
t.key === tab.key || t.title === tab.title) instead of indexOf) and then build
the label with a safe fallback like Math.max(1, foundIndex + 1) so it never
produces "Tab 0".
---
Outside diff comments:
In
`@apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/`$workspaceId/page.tsx:
- Around line 143-159: The current openDiffPane callback scans every tab in
order so a background diff pane can be chosen before a diff pane in the
currently active tab; update openDiffPane (which uses store.getState(),
state.tabs, pane.kind and calls state.setPaneData, state.setActiveTab and
state.setActivePane) to first look for a diff pane inside the active tab (use
state.activeTab or activeTabId from state) and reuse that pane if found, and
only if not found fall back to scanning all other tabs for a diff pane; ensure
the same setPaneData/setActiveTab/setActivePane flow is applied when reusing the
active-tab pane.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 688be2d9-491d-4816-8cc9-fdc70d24c6a6
📒 Files selected for processing (17)
apps/desktop/src/renderer/routes/_authenticated/_dashboard/pending/$pendingId/buildSetupPaneLayout.tsapps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/useDefaultContextMenuActions/useDefaultContextMenuActions.tsxapps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/BrowserPane/BrowserPane.tsxapps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/BrowserPane/index.tsapps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/usePaneRegistry.tsxapps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/useV2PresetExecution/useV2PresetExecution.tsapps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/useWorkspaceHotkeys/useWorkspaceHotkeys.tsapps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/page.tsxpackages/panes/src/core/store/store.test.tspackages/panes/src/core/store/store.tspackages/panes/src/index.tspackages/panes/src/react/components/Workspace/Workspace.tsxpackages/panes/src/react/components/Workspace/components/Tab/components/Pane/Pane.tsxpackages/panes/src/react/components/Workspace/index.tspackages/panes/src/react/components/Workspace/utils/resolveTabTitle.tspackages/panes/src/react/index.tspackages/panes/src/react/types.ts
💤 Files with no reviewable changes (4)
- apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/useWorkspaceHotkeys/useWorkspaceHotkeys.ts
- apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/BrowserPane/BrowserPane.tsx
- packages/panes/src/core/store/store.test.ts
- apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/BrowserPane/index.ts
| onlyPane.titleOverride ?? registry[onlyPane.kind]?.getTitle?.(onlyPane); | ||
| if (fromPane) return fromPane; | ||
| } | ||
| return `Tab ${tabs.indexOf(tab) + 1}`; |
Contributor
There was a problem hiding this comment.
Fallback can produce Tab 0 when tab is not the same object reference.
Line 17 uses tabs.indexOf(tab), which depends on referential equality; if callers pass an equivalent tab object, index becomes -1 and UI label becomes Tab 0.
🔧 Suggested fix
- return `Tab ${tabs.indexOf(tab) + 1}`;
+ const idx = tabs.findIndex((t) => t.id === tab.id);
+ return `Tab ${Math.max(0, idx) + 1}`;🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/panes/src/react/components/Workspace/utils/resolveTabTitle.ts` at
line 17, The fallback uses tabs.indexOf(tab) which can return -1 for equivalent
but non-identical tab objects; update resolveTabTitle to compute index with a
robust lookup (e.g., use tabs.findIndex(t => t.id === tab.id || t.key ===
tab.key || t.title === tab.title) instead of indexOf) and then build the label
with a safe fallback like Math.max(1, foundIndex + 1) so it never produces "Tab
0".
Unnavigated browser panes had their pane header fall through to pane.id (a raw UUID) because getTitle returned undefined for about:blank and the old titleOverride: "Browser" default was removed along with the other auto-default titleOverride writes.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
2 issues found across 17 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/usePaneRegistry.tsx">
<violation number="1" location="apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/usePaneRegistry.tsx:271">
P3: Use `.host` instead of `.hostname` to preserve the port in browser tab titles. Currently `localhost:3000` and `localhost:4000` both resolve to `"localhost"`, making them indistinguishable.</violation>
<violation number="2" location="apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/usePaneRegistry.tsx:274">
P2: Fresh browser panes display a raw UUID. When URL is `about:blank` and `pageTitle` is unset, `getTitle` returns `undefined`. Combined with the removal of `titleOverride: "Browser"` from `addBrowserTab`, the fallback in `Pane.tsx` resolves to `pane.id` (a UUID string). Return `"Browser"` here instead of `undefined`.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| return new URL(data.url).hostname; | ||
| } catch {} | ||
| } | ||
| return undefined; |
Contributor
There was a problem hiding this comment.
P2: Fresh browser panes display a raw UUID. When URL is about:blank and pageTitle is unset, getTitle returns undefined. Combined with the removal of titleOverride: "Browser" from addBrowserTab, the fallback in Pane.tsx resolves to pane.id (a UUID string). Return "Browser" here instead of undefined.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/usePaneRegistry.tsx, line 274:
<comment>Fresh browser panes display a raw UUID. When URL is `about:blank` and `pageTitle` is unset, `getTitle` returns `undefined`. Combined with the removal of `titleOverride: "Browser"` from `addBrowserTab`, the fallback in `Pane.tsx` resolves to `pane.id` (a UUID string). Return `"Browser"` here instead of `undefined`.</comment>
<file context>
@@ -262,9 +263,15 @@ export function usePaneRegistry(
+ return new URL(data.url).hostname;
+ } catch {}
+ }
+ return undefined;
},
renderPane: (ctx: RendererContext<PaneViewerData>) => (
</file context>
Suggested change
| return undefined; | |
| return "Browser"; |
URL.hostname drops the port, so localhost:3000 and localhost:4000 both rendered as "localhost" in the tab bar. URL.host keeps the port when one is explicitly set.
MocA-Love
pushed a commit
to MocA-Love/superset
that referenced
this pull request
Apr 14, 2026
…ne title resolution (superset-sh#3420) * feat(desktop): v2 diff viewer opens in its own tab + pane-derived tab titles openDiffPane now scans all tabs for an existing diff pane (focus + scroll) and falls back to addTab, so clicking a file in the Changes sidebar never hijacks the focused editor tab. Collapses tab/pane title resolution onto a single canonical field: PaneDefinition.getTitle is tightened to (pane) => string, file's rich JSX moves into the existing renderTitle hook, and a new resolveTabTitle helper powers both the tab bar and the "Move to Tab" context menu. tab.titleOverride is reserved for user renames; every auto-default caller is stripped and multi-pane tabs fall back to "Tab N" instead of "tab-<uuid>". * feat(desktop): pane-derived tab titles reserve tab.titleOverride for user renames Preset execution and workspace bootstrap were baking preset.name / terminal.label onto tab.titleOverride, which meant those names persisted misleadingly after a tab was split and couldn't be distinguished from a real user rename. Move both to the pane's titleOverride instead, and teach resolveTabTitle to read pane.titleOverride before falling through to getTitle() for single-pane tabs. tab.titleOverride is now written only by the tab-bar rename action; splitting a named tab flips the label to "Tab N" while the pane keeps its name in its header, and user renames still win over everything. * fix(desktop): browser.getTitle falls back to "Browser" for about:blank Unnavigated browser panes had their pane header fall through to pane.id (a raw UUID) because getTitle returned undefined for about:blank and the old titleOverride: "Browser" default was removed along with the other auto-default titleOverride writes. * fix(desktop): browser tab title uses URL.host to preserve port URL.hostname drops the port, so localhost:3000 and localhost:4000 both rendered as "localhost" in the tab bar. URL.host keeps the port when one is explicitly set.
MocA-Love
pushed a commit
to MocA-Love/superset
that referenced
this pull request
Apr 14, 2026
…ff viewer Follow-up fixes for superset-sh#3403 and superset-sh#3420 cherry-picks: hotkeys/types.ts: - Widen PlatformKey and HotkeyDefinition.key to allow null per platform (mirrors upstream superset-sh#3422; needed here because v1 workspace uses fork's tRPC-based PREV/NEXT_WORKSPACE handlers that reference null-bound keys) hotkeys/registry.ts: - Re-add PREV_TAB, NEXT_TAB, PREV_WORKSPACE, NEXT_WORKSPACE as null-bound (matches upstream superset-sh#3422 final state; deleted by superset-sh#3403's auto-merge but fork still needs the IDs for v1 tRPC-based workspace nav handlers) hotkeys/useRecordHotkeys.ts: - Null-guard canonicalizeChord(defaultKey) so recording a new chord for an unbound hotkey doesn't throw routes/workspace/$workspaceId/page.tsx: - Restore navigateToWorkspace import (removed by cherry-pick auto-merge); fork's tRPC-based PREV/NEXT_WORKSPACE handlers still need it routes/v2-workspace/$workspaceId/page.tsx: - Remove tabTitle argument from openPane call (deprecated by superset-sh#3420; pane-level titleOverride handles tab titles now via resolveTabTitle) FORK NOTE: the registry entries and types.ts widening overlap with PR#2 (superset-sh#3422 cherry-pick). When both PRs merge, git detects identical changes and auto-resolves.
Merged
13 tasks
MocA-Love
pushed a commit
to MocA-Love/superset
that referenced
this pull request
Apr 14, 2026
…ne title resolution (superset-sh#3420) * feat(desktop): v2 diff viewer opens in its own tab + pane-derived tab titles openDiffPane now scans all tabs for an existing diff pane (focus + scroll) and falls back to addTab, so clicking a file in the Changes sidebar never hijacks the focused editor tab. Collapses tab/pane title resolution onto a single canonical field: PaneDefinition.getTitle is tightened to (pane) => string, file's rich JSX moves into the existing renderTitle hook, and a new resolveTabTitle helper powers both the tab bar and the "Move to Tab" context menu. tab.titleOverride is reserved for user renames; every auto-default caller is stripped and multi-pane tabs fall back to "Tab N" instead of "tab-<uuid>". * feat(desktop): pane-derived tab titles reserve tab.titleOverride for user renames Preset execution and workspace bootstrap were baking preset.name / terminal.label onto tab.titleOverride, which meant those names persisted misleadingly after a tab was split and couldn't be distinguished from a real user rename. Move both to the pane's titleOverride instead, and teach resolveTabTitle to read pane.titleOverride before falling through to getTitle() for single-pane tabs. tab.titleOverride is now written only by the tab-bar rename action; splitting a named tab flips the label to "Tab N" while the pane keeps its name in its header, and user renames still win over everything. * fix(desktop): browser.getTitle falls back to "Browser" for about:blank Unnavigated browser panes had their pane header fall through to pane.id (a raw UUID) because getTitle returned undefined for about:blank and the old titleOverride: "Browser" default was removed along with the other auto-default titleOverride writes. * fix(desktop): browser tab title uses URL.host to preserve port URL.hostname drops the port, so localhost:3000 and localhost:4000 both rendered as "localhost" in the tab bar. URL.host keeps the port when one is explicitly set.
MocA-Love
pushed a commit
to MocA-Love/superset
that referenced
this pull request
Apr 14, 2026
…ff viewer Follow-up fixes for superset-sh#3403 and superset-sh#3420 cherry-picks: hotkeys/types.ts: - Widen PlatformKey and HotkeyDefinition.key to allow null per platform (mirrors upstream superset-sh#3422; needed here because v1 workspace uses fork's tRPC-based PREV/NEXT_WORKSPACE handlers that reference null-bound keys) hotkeys/registry.ts: - Re-add PREV_TAB, NEXT_TAB, PREV_WORKSPACE, NEXT_WORKSPACE as null-bound (matches upstream superset-sh#3422 final state; deleted by superset-sh#3403's auto-merge but fork still needs the IDs for v1 tRPC-based workspace nav handlers) hotkeys/useRecordHotkeys.ts: - Null-guard canonicalizeChord(defaultKey) so recording a new chord for an unbound hotkey doesn't throw routes/workspace/$workspaceId/page.tsx: - Restore navigateToWorkspace import (removed by cherry-pick auto-merge); fork's tRPC-based PREV/NEXT_WORKSPACE handlers still need it routes/v2-workspace/$workspaceId/page.tsx: - Remove tabTitle argument from openPane call (deprecated by superset-sh#3420; pane-level titleOverride handles tab titles now via resolveTabTitle) FORK NOTE: the registry entries and types.ts widening overlap with PR#2 (superset-sh#3422 cherry-pick). When both PRs merge, git detects identical changes and auto-resolves.
MocA-Love
pushed a commit
to MocA-Love/superset
that referenced
this pull request
Apr 14, 2026
All 9 upstream commits have been individually cherry-picked via PR#159~#163: | Upstream | Our PR | Description | |---|---|---| | d656b7e (superset-sh#3415) | #159 (PR#1) | terminal clipboard handling | | 31fcf19 (superset-sh#3416) | #162 (PR#4) | v1 split pane startup sizing fix | | 039edf2 (superset-sh#3403) | #161 (PR#3) | Cmd+Alt+Arrow spatial pane focus | | b18a00c (superset-sh#3421) | #159 (PR#1) | v2 right sidebar toggle reactive | | 3dd1de2 (superset-sh#3420) | #161 (PR#3) | v2 diff viewer + tab title resolution | | b42a114 (superset-sh#3418) | #159 (PR#1) | CodeMirror hotkey enablement | | c925f4d (superset-sh#3422) | #160 (PR#2) | unbound defaults + restore prev/next tab/workspace | | bb12c09 (superset-sh#3419) | #163 (PR#5) | version bump 1.5.3 | | 47efa73 (superset-sh#3432) | #159 (PR#1) | pending/update-required error selectable | Fork-specific features preserved: - auto-updater (IS_FORK, GitHub Releases API) - QuitMode/cleanupMainWindowResources lifecycle - GitHubSyncService, SpreadsheetViewer - BROWSER_RELOAD / BROWSER_HARD_RELOAD / SEARCH_IN_FILES hotkeys - HotkeyCategory "Browser" - v1 deep-link navigation (useSearch/WorkspaceSearchParams) - v1 tRPC-based PREV/NEXT_WORKSPACE handlers - v1 CLOSE_TERMINAL/CLOSE_TAB hotkey handlers - v2 extra state (rightSidebarOpenViewWidth, showPresetsBar)
9 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openDiffPanescans all tabs for an existing diff pane (focuses + scrolls to the clicked file) and otherwise falls through toaddTabdirectly. Manual splits still work; re-clicking from the sidebar finds a split-out diff pane in any tab rather than duplicating.PaneDefinition.getTitleis tightened from(ctx) => ReactNodeto(pane) => string | undefined. The file pane's rich JSX (italic-when-unpinned + has-changes dot) moves into the existingrenderTitlehook where it belongs; 5 of 6 pane kinds already returned strings. A newresolveTabTitle(tab, tabs, registry)helper powers both the tab bar (Workspace.tsx) and the "Move to Tab" context menu (useDefaultContextMenuActions) — sotab-<uuid>labels are gone from everywhere they used to leak.tab.titleOverrideis reserved for user renames only. Every auto-default caller stripped:openFilePane/addTerminalTab/addChatTab/addBrowserTab, the threeuseWorkspaceHotkeysopeners, the|| "Terminal"fallback inuseV2PresetExecution, preset execution'spreset.name(now lives on the pane), andbuildSetupPaneLayout'st.label(now lives on the pane).resolveTabTitlereadspane.titleOverride ?? registry[kind].getTitle(pane)for single-pane tabs, user rename wins over everything, and multi-pane tabs fall back toTab Nby LTR index.getBrowserTabTitlefree function deleted (duplicatedbrowser.getTitle),tabTitleparameter dropped fromstore.openPaneand its test updated,WorkspaceProps.getTabTitleprop deleted.Test plan
bun run typecheck— all 25 packages passbun run lint:fix— cleanbun test packages/panes— 71/71tab-<uuid>tab-<uuid>)Summary by cubic
The v2 diff viewer opens in its own tab and never steals focus. Tab titles are pane‑derived and consistent; user renames win, “about:blank” shows “Browser”, and browser titles now preserve ports.
New Features
resolveTabTitlein@superset/panes(user rename > single‑pane pane title > “Tab N”); the “Move to Tab” menu uses the same logic, removingtab-<uuid>labels. Browser tabs use the page title or URL host (keeps port), falling back to “Browser”.Migration
PaneDefinition.getTitlenow accepts(pane) => string | undefined. UserenderTitle(ctx)for rich JSX.WorkspaceProps.getTabTitleis removed andopenPaneno longer acceptstabTitle. UseresolveTabTitleand set auto names onpane.titleOverride; keeptab.titleOverridefor user renames only.Written for commit 7effd34. Summary will update on new commits.
Summary by CodeRabbit
Refactor
Chores
Tests