Skip to content

fix: add NEXT_PUBLIC_ELECTRIC_URL to macOS desktop build#1976

Merged
saddlepaddle merged 1 commit into
mainfrom
saddlepaddle/fix-desktop-build
Mar 3, 2026
Merged

fix: add NEXT_PUBLIC_ELECTRIC_URL to macOS desktop build#1976
saddlepaddle merged 1 commit into
mainfrom
saddlepaddle/fix-desktop-build

Conversation

@saddlepaddle
Copy link
Copy Markdown
Collaborator

@saddlepaddle saddlepaddle commented Mar 3, 2026

Summary

  • The macOS build in build-desktop.yml was missing NEXT_PUBLIC_ELECTRIC_URL in the compile env vars (Linux already had it)
  • Without this, macOS builds fall back to the hardcoded default in t3-env, which works but is inconsistent with Linux

Test plan

  • Verified Linux build already has the env var
  • Confirmed t3-env default prevents build breakage even without the secret

Summary by cubic

Add NEXT_PUBLIC_ELECTRIC_URL to the macOS desktop build so it uses the secret like Linux instead of the t3-env default. This ensures consistent Electric configuration across platforms.

Written for commit 43979d2. Summary will update on new commits.

Summary by CodeRabbit

  • Chores
    • Updated desktop application build workflow configuration to include necessary environment setup for macOS and Linux compilation phases.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 3, 2026

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 055cc6e and 43979d2.

📒 Files selected for processing (1)
  • .github/workflows/build-desktop.yml

📝 Walkthrough

Walkthrough

A GitHub Actions workflow configuration adds the NEXT_PUBLIC_ELECTRIC_URL environment variable to the build-desktop workflow's macOS and Linux build steps, sourced from secrets, to enable its usage during the Electron app compilation phase.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow
.github/workflows/build-desktop.yml
Added NEXT_PUBLIC_ELECTRIC_URL environment variable sourced from secrets to macOS and Linux build steps for the compile:app phase.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

A secret to share with the build so bright, 🐰✨
NEXT_PUBLIC_ELECTRIC_URL takes flight,
From macOS to Linux, the workflow now gleams,
With sparkling electrons fulfilling our dreams! ⚡

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description provides a clear summary and test plan but omits required template sections like Related Issues, Type of Change, Testing details, and Additional Notes. Fill out the PR description template completely by adding the missing sections: Related Issues, Type of Change checkbox, detailed Testing section, and any Additional Notes.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix: add NEXT_PUBLIC_ELECTRIC_URL to macOS desktop build' directly and specifically describes the main change in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch saddlepaddle/fix-desktop-build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@saddlepaddle saddlepaddle merged commit f0a148e into main Mar 3, 2026
13 of 14 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 3, 2026

🚀 Preview Deployment

🔗 Preview Links

Service Status Link
Neon Database (Neon) View Branch
Fly.io Electric (Fly.io) View App
Vercel API (Vercel) Open Preview
Vercel Web (Vercel) Open Preview
Vercel Marketing (Vercel) Open Preview
Vercel Admin (Vercel) Open Preview
Vercel Docs (Vercel) Open Preview

Preview updates automatically with new commits

@Kitenite Kitenite deleted the saddlepaddle/fix-desktop-build branch March 15, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant