Skip to content

ci: add NEXT_PUBLIC_ELECTRIC_URL to desktop build env#1460

Merged
saddlepaddle merged 1 commit into
mainfrom
ci/electric-url-env
Feb 13, 2026
Merged

ci: add NEXT_PUBLIC_ELECTRIC_URL to desktop build env#1460
saddlepaddle merged 1 commit into
mainfrom
ci/electric-url-env

Conversation

@saddlepaddle
Copy link
Copy Markdown
Collaborator

@saddlepaddle saddlepaddle commented Feb 13, 2026

Summary

  • Pass NEXT_PUBLIC_ELECTRIC_URL secret to the desktop build step so the app points at the Cloudflare Electric proxy

Test plan

  • Trigger a canary desktop build and verify the app connects to the Worker

Summary by CodeRabbit

  • Chores
    • Updated build configuration for desktop application compilation.

@saddlepaddle saddlepaddle merged commit 196ef31 into main Feb 13, 2026
5 of 6 checks passed
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 13, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The build-desktop GitHub Actions workflow was updated to include a new environment variable NEXT_PUBLIC_ELECTRIC_URL sourced from secrets, making it available during the electron-vite compilation step.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Configuration
.github/workflows/build-desktop.yml
Added NEXT_PUBLIC_ELECTRIC_URL environment variable from secrets to the "Compile app with electron-vite" build step.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐰 A secret whispered through the workflow air,
Electric URL finds its rightful place,
The build-desktop hops with newfound care,
One line of config, executed with grace! ⚡

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ci/electric-url-env

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 13, 2026

🚀 Preview Deployment

🔗 Preview Links

Service Status Link
Neon Database (Neon) View Branch
Fly.io Electric (Fly.io) View App
Fly.io Streams (Fly.io) View App
Vercel API (Vercel) Open Preview
Vercel Web (Vercel) Open Preview
Vercel Marketing (Vercel) Open Preview
Vercel Admin (Vercel) Open Preview
Vercel Docs (Vercel) Open Preview

Preview updates automatically with new commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant