feat(desktop): generate ports.json in setup and fix static ports watcher#1479
Merged
Conversation
Setup script now generates .superset/ports.json with human-readable labels for all allocated ports. Also fixes the static ports subscription which was passing an empty workspaceId, causing the file watcher to never start.
Contributor
📝 WalkthroughWalkthroughThis pull request adds port management functionality by introducing a ports.json generation mechanism in the setup script, adding a global subscription endpoint for port changes across all workspaces in the TRPC router, and updating the frontend hook to use this new global subscription instead of per-workspace subscriptions. Changes
Sequence DiagramsequenceDiagram
participant Client as Renderer Hook
participant Server as TRPC Router
participant Watchers as Workspace Watchers
Client->>Server: Subscribe to subscribeAllStatic
Server->>Watchers: Initialize watchers for all workspaces
Watchers-->>Server: Ready
Server-->>Client: Subscription active
Note over Watchers: Monitor workspace port changes
Watchers->>Server: Port change detected
Server->>Client: Emit {type: "change", workspaceId}
Client->>Client: Invalidate getAllStatic cache
Client->>Server: Unsubscribe
Server->>Watchers: Unwatch all workspaces
Watchers-->>Server: Cleanup complete
Server-->>Client: Subscription closed
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 3❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts (beta)
No actionable comments were generated in the recent review. 🎉 🧹 Recent nitpick comments
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
This was referenced Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setup script now generates .superset/ports.json with human-readable labels for all allocated ports. Also fixes the static ports subscription which was passing an empty workspaceId, causing the file watcher to never start.
Description
Related Issues
Type of Change
Testing
Screenshots (if applicable)
Additional Notes
Summary by CodeRabbit
Release Notes