Skip to content

Properly set code inspector port in setup script#1446

Merged
saddlepaddle merged 1 commit into
mainfrom
fix/port-5678-registration
Feb 12, 2026
Merged

Properly set code inspector port in setup script#1446
saddlepaddle merged 1 commit into
mainfrom
fix/port-5678-registration

Conversation

@saddlepaddle
Copy link
Copy Markdown
Collaborator

@saddlepaddle saddlepaddle commented Feb 12, 2026

Description

Related Issues

Type of Change

  • Bug fix
  • New feature
  • Documentation
  • Refactor
  • Other (please describe):

Testing

Screenshots (if applicable)

Additional Notes

Summary by CodeRabbit

  • Chores
    • Added dedicated port configuration for code inspector functionality in the application setup and build configuration systems.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 12, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This PR introduces a new CODE_INSPECTOR_PORT to the port allocation logic in the setup script and wires it into the electron vite configuration. The port is calculated as BASE + 10 and is included in environment variable generation and the code inspector plugin configuration.

Changes

Cohort / File(s) Summary
Port Allocation & Setup
.superset/setup.sh
Adds CODE_INSPECTOR_PORT (BASE + 10) to port offset declarations and includes it in environment variable generation alongside existing ports (WEB, API, MARKETING, ADMIN, etc.).
Electron Vite Configuration
apps/desktop/electron.vite.config.ts
Wires CODE_INSPECTOR_PORT from environment into codeInspectorPlugin configuration with numeric parsing and fallback handling.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐰 A port for inspection, port BASE plus ten,
Where code flows and rabbits peek through the zen,
New channels align, environment grows,
Electron and Vite dance as the config flows! ✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/port-5678-registration

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@saddlepaddle saddlepaddle changed the title WIP Properly set code inspector port Feb 12, 2026
@saddlepaddle saddlepaddle changed the title Properly set code inspector port Properly set code inspector port in setup script Feb 12, 2026
@saddlepaddle saddlepaddle merged commit c35ec51 into main Feb 12, 2026
7 of 14 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 12, 2026

🚀 Preview Deployment

🔗 Preview Links

Service Status Link
Neon Database (Neon) View Branch
Fly.io Electric (Fly.io) View App
Fly.io Streams (Fly.io) View App
Vercel API (Vercel) Failed to deploy
Vercel Web (Vercel) Failed to deploy
Vercel Marketing (Vercel) Failed to deploy
Vercel Admin (Vercel) Failed to deploy
Vercel Docs (Vercel) Failed to deploy

Preview updates automatically with new commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant