Skip to content

refactor(mcp): remove redundant runtime validation in device tools #1456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
saddlepaddle wants to merge 1 commit into from
Closed

refactor(mcp): remove redundant runtime validation in device tools #1456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions packages/mcp/src/tools/devices/create-workspace/create-workspace.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,18 +41,6 @@ export function register(server: McpServer) {
typeof workspaceInputSchema
>[];

if (!deviceId || !projectId) {
return {
content: [
{
type: "text",
text: "Error: deviceId and projectId are required",
},
],
isError: true,
};
}

return executeOnDevice({
ctx,
deviceId,
Expand Down
7 changes: 0 additions & 7 deletions packages/mcp/src/tools/devices/delete-workspace/delete-workspace.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,6 @@ export function register(server: McpServer) {
const deviceId = args.deviceId as string;
const workspaceIds = args.workspaceIds as string[];

if (!deviceId) {
return {
content: [{ type: "text", text: "Error: deviceId is required" }],
isError: true,
};
}

return executeOnDevice({
ctx,
deviceId,
Expand Down
7 changes: 0 additions & 7 deletions packages/mcp/src/tools/devices/get-app-context/get-app-context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,6 @@ export function register(server: McpServer) {
const ctx = getMcpContext(extra);
const deviceId = args.deviceId as string;

if (!deviceId) {
return {
content: [{ type: "text", text: "Error: deviceId is required" }],
isError: true,
};
}

return executeOnDevice({
ctx,
deviceId,
Expand Down
7 changes: 0 additions & 7 deletions packages/mcp/src/tools/devices/list-projects/list-projects.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,6 @@ export function register(server: McpServer) {
const ctx = getMcpContext(extra);
const deviceId = args.deviceId as string;

if (!deviceId) {
return {
content: [{ type: "text", text: "Error: deviceId is required" }],
isError: true,
};
}

return executeOnDevice({
ctx,
deviceId,
Expand Down
7 changes: 0 additions & 7 deletions packages/mcp/src/tools/devices/list-workspaces/list-workspaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,6 @@ export function register(server: McpServer) {
const ctx = getMcpContext(extra);
const deviceId = args.deviceId as string;

if (!deviceId) {
return {
content: [{ type: "text", text: "Error: deviceId is required" }],
isError: true,
};
}

return executeOnDevice({
ctx,
deviceId,
Expand Down
7 changes: 0 additions & 7 deletions packages/mcp/src/tools/devices/navigate-to-workspace/navigate-to-workspace.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,6 @@ export function register(server: McpServer) {
const workspaceId = args.workspaceId as string | undefined;
const workspaceName = args.workspaceName as string | undefined;

if (!deviceId) {
return {
content: [{ type: "text", text: "Error: deviceId is required" }],
isError: true,
};
}

if (!workspaceId && !workspaceName) {
return {
content: [
Expand Down
7 changes: 0 additions & 7 deletions packages/mcp/src/tools/devices/switch-workspace/switch-workspace.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,6 @@ export function register(server: McpServer) {
const workspaceId = args.workspaceId as string | undefined;
const workspaceName = args.workspaceName as string | undefined;

if (!deviceId) {
return {
content: [{ type: "text", text: "Error: deviceId is required" }],
isError: true,
};
}

if (!workspaceId && !workspaceName) {
return {
content: [
Expand Down
7 changes: 0 additions & 7 deletions packages/mcp/src/tools/devices/update-workspace/update-workspace.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,6 @@ export function register(server: McpServer) {
const deviceId = args.deviceId as string;
const updates = args.updates as z.infer<typeof workspaceUpdateSchema>[];

if (!deviceId) {
return {
content: [{ type: "text", text: "Error: deviceId is required" }],
isError: true,
};
}

return executeOnDevice({
ctx,
deviceId,
Expand Down
Loading