refactor(mcp): remove redundant runtime validation in device tools

[saddlepaddle]

Summary

• Removes manual if (!deviceId) runtime checks from 8 MCP device tools
• Zod schema validation already enforces required fields before handlers run, making these checks dead code
• Affected tools: get_app_context, list_workspaces, list_projects, create_workspace, delete_workspace, navigate_to_workspace, switch_workspace, update_workspace

Test plan

• Typecheck passes
• Stress tested all MCP tools — all read/write paths working

Summary by CodeRabbit

• Refactor
  • Simplified input validation logic across device management tools for workspace and project operations. Removed redundant runtime validation checks that duplicate existing schema-level constraints, reducing code complexity and streamlining execution flow. System validation requirements remain enforced through the input schema, maintaining data integrity.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR removes redundant runtime validation checks for deviceId (and projectId in one case) across eight device management tool modules, eliminating early-exit error paths and relying on input schema validation instead. Control flow now delegates validation responsibility to the downstream executeOnDevice function.

Changes

Cohort / File(s)	Summary
Device Tools - Input Validation Removal packages/mcp/src/tools/devices/create-workspace/create-workspace.ts, delete-workspace/delete-workspace.ts, get-app-context/get-app-context.ts, list-projects/list-projects.ts, list-workspaces/list-workspaces.ts, navigate-to-workspace/navigate-to-workspace.ts, switch-workspace/switch-workspace.ts, update-workspace/update-workspace.ts	Removed redundant runtime validation guards for deviceId parameter. Since deviceId is already marked as required in input schemas, explicit runtime checks returning error objects are eliminated. Validation responsibility shifts to schema and downstream executeOnDevice logic. Total 54 lines removed across 8 files.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• feat(mcp,desktop): bulk workspace operations #1088 — Modifies the same MCP device tool modules with changes to input handling and tool execution flow.
• feat(mcp): require workspaceId in start_claude_session and return path from create_workspace #1274 — Modifies create-workspace.ts with projectId validation and input parameter changes.
• fix(mcp): restrict device execution to user's own devices #1403 — Adds ownership/validation checks within executeOnDevice, which now handles validation previously performed in individual tools.

Poem

🐰 Hop skip and jump, the checks take a bow,
Schema's our guardian, we trust it now!
Nine guards removed with a swift git command,
Cleaner, leaner code across the land! ✨

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately and concisely summarizes the main change: removing redundant runtime validation from device tools in the MCP codebase.
Description check	✅ Passed	The PR description is mostly complete and follows the template. It includes a summary of changes and a test plan, though it lacks explicit sections for Related Issues, Type of Change, and Additional Notes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into main

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch mcp-cleanup-redundant-validation

---

No actionable comments were generated in the recent review. 🎉

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🚀 Preview Deployment

🔗 Preview Links

Service	Status	Link
Database (Neon)	✅	View Branch
Electric (Fly.io)	✅	View App
Streams (Fly.io)	✅	View App
API (Vercel)	✅	Open Preview
Web (Vercel)	✅	Open Preview
Marketing (Vercel)	✅	Open Preview
Admin (Vercel)	✅	Open Preview
Docs (Vercel)	✅	Open Preview

---

Preview updates automatically with new commits