fix(desktop): prevent setFocusedPane from clearing loading state

[Kitenite]

Summary

• setFocusedPane was unconditionally setting pane status to "idle", which falsely cleared "working" state when clicking on an active pane
• Extracted acknowledgedStatus() helper to centralize status-acknowledgment logic and prevent future inconsistencies

Changes

• apps/desktop/src/shared/tabs-types.ts: Added acknowledgedStatus() — resolves what a pane status should become when the user acknowledges it (review→idle, permission→working, working/idle unchanged)
• apps/desktop/src/renderer/stores/tabs/store.ts: Replaced inline status transition logic in setActiveTab, setFocusedPane, and clearWorkspaceAttentionStatus with the new helper

Test Plan

• Start an agent task, click on the pane while it's working — status should remain "working"
• Let an agent finish on a background tab, switch to it — "review" status clears to "idle"
• Trigger a permission prompt on a background tab, switch to it — "permission" transitions to "working"

Summary by CodeRabbit

• Refactor
  • Improved consistency of tab and pane status transitions for more reliable state management during workspace interactions.

[coderabbitai]

📝 Walkthrough

Walkthrough

A centralized acknowledgedStatus() resolver function is introduced to standardize status transitions across tab and pane updates. The function maps "review"→"idle" and "permission"→"working" statuses, replacing ad-hoc transitions throughout the tabs store with consistent, derived status values.

Changes

Cohort / File(s)	Summary
Status Resolution Utility apps/desktop/src/shared/tabs-types.ts	New acknowledgedStatus() function exported to map pane statuses on user acknowledgment: "review"→"idle", "permission"→"working", with others unchanged and undefined defaulting to "idle".
Tabs Store Integration apps/desktop/src/renderer/stores/tabs/store.ts	Replaces ad-hoc status transitions with acknowledgedStatus() resolver calls across multiple update paths: setActiveTab, setFocusedPane, clearWorkspaceAttentionStatus, and tab/pane mutation operations, ensuring consistent status derivation throughout the store.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• feat(desktop): add 3-color workspace status indicators #588: Introduces status/type handling and status-driven flows that this PR builds upon by centralizing status resolution logic.
• refactor(desktop): replace terminal pane path nav with name and status #1328: Refactors tabs store mutations and pane naming, sharing the same codebase for status and update path modifications.
• refactor window to tabs lmao  #284: Modifies tabs store and pane/tab status management in setActive and setFocusedPane paths, overlapping with the integration areas in this PR.

Poem

🐰 A mapper true, so clean and neat,
Transforms those statuses quite sweet,
From "review" to "idle," permission's plea,
One function rules them, unified spree,
Status resolved, harmoniously! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main fix—preventing setFocusedPane from clearing the loading/working state—which is the primary issue addressed in the changeset.
Description check	✅ Passed	The PR description is comprehensive and well-structured. It clearly explains the problem, lists the files changed, provides implementation details, and includes a concrete test plan covering the key scenarios.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch kitenite/loading-state

---

No actionable comments were generated in the recent review. 🎉

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

• ⚠️ Neon database branch
• ⚠️ Electric Fly.io app
• ⚠️ Streams Fly.io app

Thank you for your contribution! 🎉