refactor(desktop): replace terminal pane path nav with name and status#1328
Conversation
…s indicator Remove the DirectoryNavigator component from the terminal pane toolbar and show the pane name with a status indicator instead, matching the tab strip pattern.
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughRemoved directory-navigation backend and frontend pieces, replaced debounced tab auto-title plumbing with a pane-scoped naming API, and updated terminal UI to show a name + status indicator instead of the DirectoryNavigator. Changes
Sequence Diagram(s)sequenceDiagram
participant Terminal as Terminal Component
participant Hooks as useTerminalLifecycle / useTerminalRefs
participant Store as Tabs Store
participant UI as Tab/Pane UI
Terminal->>Hooks: emit title update (paneId, title)
Hooks->>Store: call setPaneName(paneId, title)
Store->>Store: deriveTabName(panes, tabId)
Store->>UI: update tab title/state
UI-->>Terminal: render updated name/status
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
Summary
DirectoryNavigatorcomponent from the terminal pane toolbar, which provided an interactive folder-browsing popoverChanges
DirectoryNavigatorwith pane name text +StatusIndicatorcomponentlistDirectoryprocedure and unusednode:fs/promises/node:pathimportsTest Plan
Summary by CodeRabbit