fix(desktop): nested hidden files not showing when toggle enabled

[de1mat]

Summary

Fixes an issue where nested hidden folders/files don't appear when "Show Hidden Files" is enabled in the file browser.

Root cause: The toggle only invalidated the root directory's children cache, so nested expanded folders kept their stale children (fetched with includeHidden: false).

Fix:

• Update the ref synchronously before invalidation so getChildren uses the correct includeHidden value
• Invalidate all expanded directories on toggle, not just root

Test plan

1. Open a workspace with nested folders containing hidden items (e.g., .github/ inside a subfolder)
2. Expand the folder tree to show nested folders
3. Toggle "Show Hidden Files" on
4. Verify hidden folders/files appear at all levels, not just root

Closes #1193

Summary by CodeRabbit

• Bug Fixes
  • Fixed hidden file visibility toggle to properly refresh all nested directories, ensuring hidden files within subdirectories display correctly when visibility settings are changed.

[coderabbitai]

📝 Walkthrough

Walkthrough

Modified the hidden files toggle functionality in FilesView to synchronously update the showHiddenFilesRef with a computed value. Expanded invalidation logic to iterate through all items and invalidate children IDs for directories, ensuring nested hidden files load correctly when visibility is toggled.

Changes

Cohort / File(s)	Summary
Hidden Files Toggle Enhancement apps/desktop/src/renderer/screens/main/components/WorkspaceView/RightSidebar/FilesView/FilesView.tsx	Enhanced state management by synchronously updating showHiddenFilesRef.current with computed newValue. Expanded invalidation logic to iterate through all items and invalidate children IDs for directories, replacing previous behavior that only invalidated the root item.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Fix file tree staying stale when switching workspaces #1143: Modifies the same FilesView.tsx file with synchronously-updated showHiddenFiles ref and expanded invalidation logic using invalidateChildrenIds, indicating parallel implementation of the same enhancement.

Poem

🐰✨ A toggle so neat, a ref that's true,
Hidden files dance when we say "show, don't stew!"
Nested directories bloom in the light,
One little change makes everything right. 🌿

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately and specifically describes the main change: fixing nested hidden files not showing when the toggle is enabled.
Description check	✅ Passed	The pull request description covers all required template sections with clear explanations of the root cause, fix, and test plan, fully meeting repository standards.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In
`@apps/desktop/src/renderer/screens/main/components/WorkspaceView/RightSidebar/FilesView/FilesView.tsx`:
- Around line 270-284: The state updater in handleToggleHiddenFiles mutates
showHiddenFilesRef inside the setShowHiddenFiles functional updater which can
run later and causes invalidation to see the old value; instead compute the new
value first, synchronously assign showHiddenFilesRef.current = newValue, call
the invalidation logic (tree.getItemInstance("root")?.invalidateChildrenIds()
and iterating tree.getItems() to call invalidateChildrenIds on directories)
using that newValue, and only then call setShowHiddenFiles(newValue); remove
side effects from the updater to avoid Strict Mode double-invocation and ensure
invalidation uses the correct includeHidden state.

[Kitenite]

Superseded by #1230 which merges cleanly with main. Thank you @de1mat for the original fix!

[Kitenite]

For whatever reason i couldn't push to this PR to fix the merge conflict so i opened another one and attributed it to you.

[Kitenite]

Thanks @de1mat !