feat(desktop): persist show hidden files setting per-project

[de1mat]

Fixes #1232

Summary

Persists the "Show Hidden Files" setting per-project, so each project remembers its own preference across app restarts.

Changes:

• Convert showHiddenFiles from boolean to Record<string, boolean> keyed by project.id
• Add Zustand migration for users with legacy boolean value in localStorage
• Setting shared across all worktrees of the same project (not per-worktree)

Test plan

1. Toggle "Show Hidden Files" in a project
2. Switch to a different project - should have its own independent setting
3. Restart the app - settings should persist
4. Switch between worktrees of the same project - setting should be shared

Summary by CodeRabbit

• New Features
  • Hidden files visibility is now scoped per project, allowing users to independently control hidden file display settings for each project instead of applying a global setting across all projects.

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

File-explorer's showHiddenFiles became project-scoped (Record<string, boolean>) with a legacy key for migration. FilesView now reads per-project value, keeps a synchronous ref for loaders, calls toggleHiddenFiles(projectId), and invalidates/refetches directories when toggling.

Changes

Cohort / File(s)	Summary
FilesView component apps/desktop/src/renderer/screens/main/components/WorkspaceView/RightSidebar/FilesView/FilesView.tsx	Reads per-project showHiddenFiles (fallback to legacy), replaces local/global reads with showHiddenFilesRef for synchronous loader usage, updates handleToggleHiddenFiles(projectId) to toggle per-project setting and invalidate root/expanded directories; hook deps include projectId.
File explorer store & persistence apps/desktop/src/renderer/stores/file-explorer.ts	showHiddenFiles changed from boolean → Record<string, boolean>; added LEGACY_SHOW_HIDDEN_KEY; updated toggleHiddenFiles to accept projectId; initial state and persistence/migration updated to preserve legacy boolean under the legacy key.

Sequence Diagram(s)

sequenceDiagram
  participant UI as FilesView (UI)
  participant Store as FileExplorerStore
  participant Loader as QueryClient/Loader
  participant Cache as ExpandedTreeCache

  UI->>Store: select showHiddenFiles(projectId) (fallback legacy)
  Store-->>UI: per-project showHiddenFiles
  UI->>UI: set showHiddenFilesRef.current
  UI->>Store: toggleHiddenFiles(projectId)
  Store-->>UI: updated per-project showHiddenFiles
  UI->>Cache: get expanded directories
  UI->>Loader: invalidate queries (root + expanded dirs)
  Loader-->>UI: refetch entries (includeHidden = showHiddenFilesRef.current)

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• feat(desktop): persist show hidden files setting per-project #1223 — converts showHiddenFiles to per-project map and adds legacy migration; directly overlaps store changes.
• fix(desktop): fix show hidden files toggle being inverted on first use #1229 — addresses loader/store interaction and stale-ref timing in FilesView; related to use of showHiddenFilesRef.
• fix(desktop): nested hidden files not showing when toggle enabled #1230 — adjusts FilesView toggle/readDirectory flow and invalidation; overlaps UI invalidation logic.

Poem

🐰 I nibbled code in moonlit night,
Scoped burrows hidden out of sight.
A legacy key tucked in my paw,
Toggles hop and trees redraw —
Happy hops, hidden files in light! 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately and concisely summarizes the main feature change: persisting the show hidden files setting on a per-project basis.
Description check	✅ Passed	The PR description comprehensively covers all required template sections: clear summary, related issue, type of change, testing plan, and additional context.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🤖 Fix all issues with AI agents

In
`@apps/desktop/src/renderer/screens/main/components/WorkspaceView/RightSidebar/FilesView/FilesView.tsx`:
- Line 18: Update the selector inside useFileExplorerStore that reads
showHiddenFiles for a given projectId so that when showHiddenFiles[projectId] is
undefined it falls back to the migrated legacy default (e.g.,
legacyShowHiddenDefault) instead of treating it as false; locate the
selector/getter referencing showHiddenFiles and projectId and change the
conditional to use (showHiddenFiles?.[projectId] ?? LEGACY_SHOW_HIDDEN_DEFAULT).
Also extract any hardcoded magic strings/numbers used in that logic (like the
legacy default key/name and default boolean) into named constants at the top of
the module to replace inline literals.

In `@apps/desktop/src/renderer/stores/file-explorer.ts`:
- Around line 142-149: Existing migration drops legacy boolean hidden-files
preference and toggleHiddenFiles assumes missing key => false; update the
migration logic that transforms persisted state (migrate function) to copy any
legacy boolean (e.g., a top-level showHiddenFiles boolean) into the new
showHiddenFiles map under a named DEFAULT_PROJECT_KEY constant, and modify
toggleHiddenFiles(projectId) to fall back to get().showHiddenFiles[projectId] ??
get().showHiddenFiles[DEFAULT_PROJECT_KEY] ?? false so migrated users keep their
setting; also extract hardcoded strings/numbers (like the default project key
name and any version number constants used in migrate) into named constants at
the module top and use those constants in both the migrate routine and
toggleHiddenFiles.

[Kitenite]

Removed the migration and legacy key since i think it's minor enough. Thanks @de1mat!

[de1mat]

Removed the migration and legacy key since i think it's minor enough. Thanks @de1mat!

Pleasure! Funny, I only added the legacy key because CodeRabbit told me to 🤣 Looks cleaner without it 👍

[Kitenite]

No worries it's a good measure if this was a more important config