Skip to content

feat(desktop): add ctrl+tab tab navigation#1152

Merged
Kitenite merged 1 commit into
superset-sh:mainfrom
ascrazy:codex/desktop-hotkeys-tab-nav
Feb 3, 2026
Merged

feat(desktop): add ctrl+tab tab navigation#1152
Kitenite merged 1 commit into
superset-sh:mainfrom
ascrazy:codex/desktop-hotkeys-tab-nav

Conversation

@ascrazy
Copy link
Copy Markdown
Contributor

@ascrazy ascrazy commented Feb 2, 2026

Description

Adds alternate tab navigation hotkeys in the desktop app:

Ctrl+Tab → next tab
Ctrl+Shift+Tab → previous tab

These are standard shortcuts used across most apps (terminal apps, browsers, IDEs), so adding them provides a familiar, universal way for users to move between tabs quickly and efficiently.

Related Issues

-

Type of Change

  • [-] Bug fix
  • New feature
  • [-] Documentation
  • [-] Refactor
  • [-] Other (please describe):

Testing

  • Start the desktop app cd apps/desktop && SKIP_ENV_VALIDATION=1 bun run dev
  • Create new workspace
  • Open several terminal tabs (preferably 3+)
  • Use ctrl+tab / ctrl+shift+tab to navigate across terminal tabs

Screenshots (if applicable)

-

Additional Notes

-

Summary by CodeRabbit

Release Notes

  • New Features
    • Added alternative keyboard shortcuts for terminal tab navigation: Ctrl+Tab to move to the next tab and Ctrl+Shift+Tab to move to the previous tab, with wrap-around support for seamless switching.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 2, 2026

📝 Walkthrough

Walkthrough

Introduces two new keyboard shortcuts for terminal tab navigation. PREV_TAB_ALT and NEXT_TAB_ALT hotkey definitions are added to the configuration, with corresponding handlers implemented in the workspace page that mirror existing tab navigation logic with wrap-around behavior.

Changes

Cohort / File(s) Summary
Hotkey Definitions
apps/desktop/src/shared/hotkeys.ts
Added PREV_TAB_ALT ("ctrl+shift+tab") and NEXT_TAB_ALT ("ctrl+tab") hotkey entries to the HOTKEYS map in the Terminal category.
Hotkey Handlers
apps/desktop/src/renderer/routes/_authenticated/_dashboard/workspace/$workspaceId/page.tsx
Implemented PREV_TAB_ALT and NEXT_TAB_ALT handlers that navigate between tabs with wrap-around logic, mirroring existing PREV_TAB and NEXT_TAB functionality.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • CharlieHelps
  • Kitenite

Poem

🐰 A rabbit hops through tabs with glee,
With ctrl+tab and shift, so free!
Alt shortcuts bound, the navigation's swift,
Wrapping 'round in perfect drift.
New keys to dance, old logic still,
All tabs bend to our fluffy will! 🎹

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main feature: adding Ctrl+Tab keyboard shortcuts for tab navigation in the desktop app.
Description check ✅ Passed The description follows the template structure with all required sections completed: clear description of changes, type marked as new feature, testing steps provided, and related issues/screenshots appropriately noted as N/A.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Collaborator

@Kitenite Kitenite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks for adding this! Sorry for the wait

@Kitenite Kitenite merged commit 0a3b8b8 into superset-sh:main Feb 3, 2026
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants