Skip to content

feat(desktop): wrap tab navigation hotkeys#1051

Merged
saddlepaddle merged 1 commit into
mainfrom
hotkeys-wrap
Jan 29, 2026
Merged

feat(desktop): wrap tab navigation hotkeys#1051
saddlepaddle merged 1 commit into
mainfrom
hotkeys-wrap

Conversation

@saddlepaddle
Copy link
Copy Markdown
Collaborator

@saddlepaddle saddlepaddle commented Jan 29, 2026

Summary

  • PREV_TAB and NEXT_TAB hotkeys now wrap around at list boundaries instead of stopping at the first/last tab

Test plan

  • Open a workspace with multiple tabs
  • Navigate to the last tab and press NEXT_TAB (⌘⌥→) — should wrap to the first tab
  • Navigate to the first tab and press PREV_TAB (⌘⌥←) — should wrap to the last tab

Summary by CodeRabbit

  • Bug Fixes
    • Tab navigation hotkeys now properly handle edge cases, including empty tab sets
    • Tab navigation now supports wrap-around behavior—moving from the last tab cycles to the first, and vice versa

✏️ Tip: You can customize this high-level summary in your review settings.

PREV_TAB and NEXT_TAB hotkeys now wrap around instead of stopping
at the first/last tab.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 29, 2026

📝 Walkthrough

Walkthrough

Tab navigation hotkeys PREV_TAB and NEXT_TAB are enhanced with empty tab set validation and wrapping behavior. PREV_TAB moves to the last tab when at the first tab, while NEXT_TAB moves to the first tab when at the last tab.

Changes

Cohort / File(s) Summary
Tab Navigation Hotkeys
apps/desktop/src/renderer/routes/_authenticated/_dashboard/workspace/$workspaceId/page.tsx
PREV_TAB and NEXT_TAB hotkeys now guard against empty tab sets and implement wrap-around navigation for improved keyboard control flow.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Through tabs we hop, both forward and back,
Wrapping 'round smoothly, nothing we lack!
Empty guards stand tall, protection so bright,
First to last, last to first—what delight!

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description is missing several required template sections including Related Issues, Type of Change, Testing, Screenshots, and Additional Notes. Fill in the missing template sections. Add issue links if applicable, mark the 'New feature' checkbox, provide detailed test results, and include any additional context.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding wrap-around behavior to tab navigation hotkeys.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@saddlepaddle saddlepaddle merged commit e7a27ca into main Jan 29, 2026
5 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ✅ Neon database branch
  • ⚠️ Electric Fly.io app

Thank you for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant