Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type exports for subpaths #2196

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Add type exports for subpaths #2196

merged 2 commits into from
Jul 21, 2023

Conversation

connor-baer
Copy link
Member

@connor-baer connor-baer commented Jul 21, 2023

Purpose

TypeScript isn't able to resolve the types for subpath exports (e.g. @sumup/circuit-ui/legacy).

Approach and changes

  • Added conditional export conditions when using moduleResolution: nodeNext in consuming apps
  • Added typesVersions when using moduleResolution: node in consuming apps

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2023

🦋 Changeset detected

Latest commit: 3092d65

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2023 7:44pm

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #2196 (3092d65) into next (b5b0df1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #2196   +/-   ##
=======================================
  Coverage   96.56%   96.56%           
=======================================
  Files         259      259           
  Lines       20523    20523           
  Branches     1928     1928           
=======================================
  Hits        19818    19818           
  Misses        702      702           
  Partials        3        3           

@connor-baer connor-baer marked this pull request as ready for review July 21, 2023 19:49
@connor-baer connor-baer requested a review from a team as a code owner July 21, 2023 19:49
@connor-baer connor-baer requested review from pdrmdrs and removed request for a team July 21, 2023 19:49
@connor-baer connor-baer merged commit d3e35be into next Jul 21, 2023
8 checks passed
@connor-baer connor-baer deleted the fix/subpath-types branch July 21, 2023 19:50
@connor-baer connor-baer mentioned this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant