Throw error for missing as prop
#2195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: adef67b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## next #2195 +/- ##
==========================================
- Coverage 96.56% 96.52% -0.05%
==========================================
Files 259 259
Lines 20523 20544 +21
Branches 1928 1931 +3
==========================================
+ Hits 19818 19830 +12
- Misses 702 711 +9
Partials 3 3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The Title, Headline, and SubHeadline components no longer default to the
h2element. Developers need to specify the element explicitly so that they are forced to consider the correct heading level.When the
asprop is missing, React throws a generic error message that makes it difficult to pinpoint in which component the error occurred.Approach and changes
asprop isn't provided to the Title, Headline, and SubHeadline componentsDefinition of done