-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add component-lifecycle-imports ESLint rule #2164
Conversation
🦋 Changeset detectedLatest commit: 868ff5d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## next #2164 +/- ##
==========================================
+ Coverage 96.55% 96.57% +0.02%
==========================================
Files 258 259 +1
Lines 20338 20481 +143
Branches 1922 1938 +16
==========================================
+ Hits 19637 19780 +143
Misses 693 693
Partials 8 8
|
2a5d569
to
868ff5d
Compare
Relates to #2094.
Purpose
Circuit UI v7 introduces the new
experimental
andlegacy
component lifecycle stages. Components in those stages are exported from separate package entry points. This means the imports for components that have transitioned to a different stage must be updated. This can be automated using a custom ESLint rule.Approach and changes
circuit-ui/component-lifecycle-imports
rule to update component imports when they move to a different lifecycle stageDefinition of done