Add component-lifecycle-imports ESLint rule #2164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 868ff5d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## next #2164 +/- ##
==========================================
+ Coverage 96.55% 96.57% +0.02%
==========================================
Files 258 259 +1
Lines 20338 20481 +143
Branches 1922 1938 +16
==========================================
+ Hits 19637 19780 +143
Misses 693 693
Partials 8 8
|
connor-baer
force-pushed
the
feature/component-lifecycle-imports
branch
from
2a5d569
to
868ff5d
Compare
tareqlol
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #2094.
Purpose
Circuit UI v7 introduces the new
experimentalandlegacycomponent lifecycle stages. Components in those stages are exported from separate package entry points. This means the imports for components that have transitioned to a different stage must be updated. This can be automated using a custom ESLint rule.Approach and changes
circuit-ui/component-lifecycle-importsrule to update component imports when they move to a different lifecycle stageDefinition of done