-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise minimum React version #1992
Conversation
🦋 Changeset detectedLatest commit: f1457a1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Running into storybookjs/storybook#21034. Edit: Fixed in f357e14. |
Codecov Report
@@ Coverage Diff @@
## next #1992 +/- ##
==========================================
- Coverage 92.15% 91.52% -0.64%
==========================================
Files 168 169 +1
Lines 3532 3527 -5
Branches 1220 1205 -15
==========================================
- Hits 3255 3228 -27
- Misses 256 279 +23
+ Partials 21 20 -1
|
cdf5ba5
to
b93f6a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
packages/circuit-ui/components/Carousel/__snapshots__/Carousel.spec.js.snap
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well this looks good to me! I'm happy to take another look when this is marked ready for review if you'd like.
b93f6a6
to
f1457a1
Compare
Addresses DSYS-371. Relates to #1998.
Purpose
Circuit UI has supported React 18 since #1554 while continuing to support older versions of React (>=16.8). React 18 introduced APIs to support the new concurrent rendering mode. Circuit UI must adopt these APIs, which requires raising the minimum React version to React 18.
Approach and changes
react
andreact-dom
peer dependencies to >=18uniqueId
util and replace it with the newuseId
hookDefinition of done