Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise minimum React version #1992

Merged
merged 4 commits into from
Apr 22, 2023
Merged

Raise minimum React version #1992

merged 4 commits into from
Apr 22, 2023

Conversation

connor-baer
Copy link
Member

@connor-baer connor-baer commented Mar 14, 2023

Addresses DSYS-371. Relates to #1998.

Purpose

Circuit UI has supported React 18 since #1554 while continuing to support older versions of React (>=16.8). React 18 introduced APIs to support the new concurrent rendering mode. Circuit UI must adopt these APIs, which requires raising the minimum React version to React 18.

Approach and changes

  • Raise the minimum version of the react and react-dom peer dependencies to >=18
  • Deprecate the uniqueId util and replace it with the new useId hook

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@changeset-bot
Copy link

changeset-bot bot commented Mar 14, 2023

🦋 Changeset detected

Latest commit: f1457a1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2023 8:09pm

@connor-baer
Copy link
Member Author

connor-baer commented Mar 14, 2023

Running into storybookjs/storybook#21034.

Edit: Fixed in f357e14.

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #1992 (cdf5ba5) into next (1267c69) will decrease coverage by 0.64%.
The diff coverage is 97.87%.

❗ Current head cdf5ba5 differs from pull request most recent head f1457a1. Consider uploading reports for the commit f1457a1 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1992      +/-   ##
==========================================
- Coverage   92.15%   91.52%   -0.64%     
==========================================
  Files         168      169       +1     
  Lines        3532     3527       -5     
  Branches     1220     1205      -15     
==========================================
- Hits         3255     3228      -27     
- Misses        256      279      +23     
+ Partials       21       20       -1     
Impacted Files Coverage Δ
packages/circuit-ui/util/id.ts 100.00% <ø> (ø)
...ages/circuit-ui/hooks/useFocusList/useFocusList.ts 95.00% <93.33%> (+0.26%) ⬆️
...ckages/circuit-ui/components/Checkbox/Checkbox.tsx 100.00% <100.00%> (+13.79%) ⬆️
...cuit-ui/components/CurrencyInput/CurrencyInput.tsx 100.00% <100.00%> (ø)
...es/circuit-ui/components/ImageInput/ImageInput.tsx 83.96% <100.00%> (+0.15%) ⬆️
packages/circuit-ui/components/Input/Input.tsx 93.61% <100.00%> (+0.13%) ⬆️
...rcuit-ui/components/ModalContext/createUseModal.ts 100.00% <100.00%> (ø)
packages/circuit-ui/components/Popover/Popover.tsx 96.29% <100.00%> (ø)
.../circuit-ui/components/ProgressBar/ProgressBar.tsx 95.23% <100.00%> (+0.11%) ⬆️
.../circuit-ui/components/RadioButton/RadioButton.tsx 91.30% <100.00%> (+0.39%) ⬆️
... and 8 more

... and 30 files with indirect coverage changes

Copy link
Contributor

@robinmetral robinmetral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Contributor

@robinmetral robinmetral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well this looks good to me! I'm happy to take another look when this is marked ready for review if you'd like.

@connor-baer connor-baer marked this pull request as ready for review April 22, 2023 20:07
@connor-baer connor-baer requested a review from a team as a code owner April 22, 2023 20:07
This was referenced Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants