Skip to content

🐛(summary) clean transcript from whisperX #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

🐛(summary) clean transcript from whisperX #761

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
666aaeb
🐛(summary) clean transcript from whisperX
Oct 22, 2025
98f51bf
fixup! 🐛(summary) clean transcript from whisperX
Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/summary/summary/core/celery_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,9 @@ def format_segments(transcription_data):
else:
formatted_output += f" {text}"
previous_speaker = speaker
formatted_output = formatted_output.replace(
"Vap'n'Roll Thierry", "[texte impossible à transcrire]"
)
Copy link
Collaborator

@lebaudantoine lebaudantoine Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Could you try making it extensible, following the Open–Closed Principle?
I’d suggest adding a settings parameter that takes a list of tuples, so we can easily configure any desired replacements.

Also, I’m curious, could you explain why you’re performing the replacement on formatted_output instead of the original text?

Copy link
Collaborator Author

@GuittenyMartin GuittenyMartin Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did the replacement in formatting because cleaning can be considered a form of formatting but i can change it and make a cleaning function before the formatting.

return formatted_output


Expand Down
Loading