🐛(summary) clean transcript from whisperX #761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean transcript output to hide weird output from whisperX "Vap'n'Roll Thierry" is sometimes randomly predicted for no reason.
GuittenyMartin
force-pushed
the
clean-transcript
branch
from
bddd865 to
666aaeb
Compare
Comment on lines
196
to
198
| formatted_output = formatted_output.replace( | ||
| "Vap'n'Roll Thierry", "[texte impossible à transcrire]" | ||
| ) |
Collaborator
There was a problem hiding this comment.
Nice work! Could you try making it extensible, following the Open–Closed Principle?
I’d suggest adding a settings parameter that takes a list of tuples, so we can easily configure any desired replacements.
Also, I’m curious, could you explain why you’re performing the replacement on formatted_output instead of the original text?
Collaborator
Author
There was a problem hiding this comment.
I did the replacement in formatting because cleaning can be considered a form of formatting but i can change it and make a cleaning function before the formatting.
GuittenyMartin
force-pushed
the
clean-transcript
branch
2 times, most recently
from
27e2d80 to
e3449aa
Compare
GuittenyMartin
force-pushed
the
clean-transcript
branch
from
e3449aa to
98f51bf
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean transcript output to hide weird output from whisperX.
"Vap'n'Roll Thierry" is sometimes randomly predicted for no reason.