Change := to += to allow projects to add their own objs to OTHER_OBJS #564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OTHER_OBJS is an undocumented, but useful, way to add extra sources to a project. Setting it with := here breaks this functionality, so I've changed it to += to not trample on the user-set value.
Owner
|
Thanks for the PR. Unfortunately I didn't get to it on time and it has resulted in some merge conflicts. Can you please update your branch and fix the merge conflict? |
Author
|
It looks like this has been obsoleted by #567, which removed this code and stopped overwriting OTHER_OBJS. Closing as unnecessary :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OTHER_OBJS is an undocumented, but useful, way to add extra sources to
a project. Setting it with := here breaks this functionality, so I've
changed it to += to not trample on the user-set value.