Support for Arduino Due added

[tuna-f1sh]

Following on from #565 , support for Arduino Due added to complete Arduino SAM support. Fairly minor changes:

• Change from use of ALT_CORE_.. to SAM_CORE.. for readability as there is a bit more going on to pull together the core files on the Arduino Due. I don't think this has any impact as it was added in the original SAM pull request.
• Catch empty CMSIS version detection to prevent basename flag complaining.
• Escape character on grep string to prevent macOS BSD grep complaining.
• Blink example for Arduino Due

[sudar]

@sej7278

What are your thoughts on this?

[sej7278]

don't understand this bit that seems to replace ALTERNATE_CORE_PATH with SAM_CORE_PATH

[sej7278]

isn't this going to break non-sam alternate cores like attiny?

edit: actually i see if was added when sam support was added, so probably ok to rename (might even be better that way!)

[sej7278]

does this need rebasing as the COLOR_WHEN stuff has already been merged?

[sej7278]

color diagnostics has already been merged, need to add Due comment to history

[sej7278]

looks like it needs rebasing as the DIAGNOSTICS_COLOR_WHEN stuff has already been merged, also need Due support added to HISTORY.md

[tuna-f1sh]

Yes the ALTERNATIVE_CORE stuff looks like a big change but as you picked up, it's something that I added when doing the SAM support and think the naming it SAM_CORE is easier for readability.

Think the DIAGNOSTICS_COLOR_WHEN stuff got pulled in as I merged upstream after starting work. I did do a rebase so I'll have to dig deeper as to how to eliminate this change, which is already in master, unless you have any tips?

[tuna-f1sh]

Ok, I sorted out why my rebase didn't adjust for the upstream/master changes; I'd rebased to my local master prior doing a merge of upstream/master.

[sej7278]

all looks good to me now

[jskang94]

void setup() {
    Serial.begin(9600);
}

void loop() {
    float foo = random(1000) * 0.001;
    Serial.println(String("foo: ") + foo);
}

this code yields this error

...
/home/kjs-ubuntu/.arduino15/packages/arduino/tools/arm-none-eabi-gcc/4.8.3-2014q1/bin/arm-none-eabi-gcc -T/home/kjs-ubuntu/.arduino15/packages/arduino/hardware/sam/1.6.11/variants/arduino_due_x/linker_scripts/gcc/flash.ld -Wl,-Map=build-arduino_due_x/DueBlink.map -o build-arduino_due_x/DueBlink.elf build-arduino_due_x/DueBlink.ino.o   /home/kjs-ubuntu/.arduino15/packages/arduino/hardware/sam/1.6.11/variants/arduino_due_x/libsam_sam3x8e_gcc_rel.a -mthumb -Wl,--cref -Wl,--check-sections -Wl,--gc-sections -Wl,--entry=Reset_Handler -Wl,--unresolved-symbols=report-all -Wl,--warn-common -Wl,--warn-section-align -Wl,--start-group -u _sbrk -u link -u _close -u _fstat -u _isatty -u _lseek -u _read -u _write -u _exit -u kill -u _getpid -L/home/kjs-ubuntu/.arduino15/packages/arduino/hardware/sam/1.6.11/system/CMSIS/CMSIS/Lib/GCC -lm  -mcpu=cortex-m3 -Wl,--gc-sections -Os build-arduino_due_x/libcore.a -Wl,--end-group
build-arduino_due_x/libcore.a(WString.cpp.o): In function `String::concat(float)':
WString.cpp:(.text._ZN6String6concatEf+0x14): undefined reference to `dtostrf'
collect2: error: ld returned 1 exit status
/home/kjs-ubuntu/project/ubdp/UDSL/submodules/ubduino/submodules/Arduino-Makefile/Arduino.mk:1554: recipe for target 'build-arduino_due_x/DueBlink.elf' failed
make: *** [build-arduino_due_x/DueBlink.elf] Error 1

there's avr directory under $(ARDUINO_CORE_PATH), and it seems like you're missing it, so adding this works ok

--- a/Arduino.mk
+++ b/Arduino.mk
@@ -830,8 +830,9 @@ ifeq ($(strip $(NO_CORE)),)
         CORE_CPP_SRCS   = $(wildcard $(ARDUINO_CORE_PATH)/*.cpp)
         CORE_AS_SRCS    = $(wildcard $(ARDUINO_CORE_PATH)/*.S)

-        # USB Core if samd or sam
+        # USB / dtostrf hack if samd or sam
         ifeq ($(findstring sam, $(strip $(ARCHITECTURE))), sam)
+            CORE_C_SRCS    += $(wildcard $(ARDUINO_CORE_PATH)/avr/*.c)
             CORE_C_SRCS    += $(wildcard $(ARDUINO_CORE_PATH)/USB/*.c)
             CORE_CPP_SRCS  += $(wildcard $(ARDUINO_CORE_PATH)/USB/*.cpp)
         endif

[tuna-f1sh]

Good spot, looks like it's just the emulation of the dtostrf - I've added it now.

[sudar]

@tuna-f1sh

Thanks for your contribution.

@sej7278

Thanks for reviewing the PR.

[tuna-f1sh]

Have a look at the [Due]( https://github.com/sudar/Arduino-Makefile/tree/master/examples/DueBlink ) example and the [ARM]( https://github.com/sudar/Arduino-Makefile/blob/master/README.md) section of the README.

…

On Sat, 13 Jul 2019 at 19:18, Will ***@***.***> wrote: Hi, reading through this post, I understand that the arduino due is now supported right? I don't see it in the supported board.txt file? could someone enlighten me on what board_tag to set and more generally how to generate the simplest makefile for the Arduino due. thx — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#567?email_source=notifications&email_token=AAOMUGSONB6ETVKDLWOOMG3P7IE7TA5CNFSM4FD3AYOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ3V2YY#issuecomment-511139171>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAOMUGRGAPMUJY4GXF3DCFTP7IE7TANCNFSM4FD3AYOA> .

[wlwatkins]

Thks, I actually saw it right after writing the comment, hence why i deleted my comment. (you know you need to dial tech support for your computer to fix ^^ ) thanks again.