-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Viscosity and conductivity from CoolProp #1819
Conversation
…into feature_coolprop
Hi, I can build this new feature and run simulation with VISCOSITY_MODEL= COOLPROP But the building process on github failed. I need your help :) Thank you. |
I suggest to click on 'Details' next to each of the regression tests and see why it fails. I saw that there are at least 2 different errors, one was for instance 'coolprop.h' not found. |
You are right, I am trying to solve these errors one by one. Thank you for your help. |
Hi, there is an issue related to code factor. It is said that (SU2_CFD/src/solvers/CIncEulerSolver.cpp) is complex code. I tried to find solution by google, but still failed. Do you have an suggestion? Thank you. |
That's ok, I think that's some kind of bug in code factor, we can't do much about that warning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please modify the existing CoolProp test case to use the models, or add a new one.
a7baac5
to
0cfb47f
Compare
I add a new config file to include the CoolProp viscosity and conductivity model. I use the same mesh, so no new mesh is required. |
Proposed Changes
This new feature aims to get viscosity and conductivity from CoolProp library.
Related Work
This project is an extension of PR #1806
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.