-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: PnP package resolution support #273
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adalinesimonian
added
type: enhancement
a new feature that isn't related to rules
status: needs discussion
labels
Oct 22, 2021
adalinesimonian
added
status: wip
is being worked on by someone
and removed
status: needs discussion
labels
Oct 22, 2021
merceyz
reviewed
Oct 22, 2021
Tests are failing in CI but are working locally for me. Going to investigate tomorrow. |
Failing tests were due to a bug that's been patched now in #285. PR is ready for review! |
adalinesimonian
added
For Milestone Issue
and removed
status: wip
is being worked on by someone
type: enhancement
a new feature that isn't related to rules
labels
Oct 28, 2021
ota-meshi
approved these changes
Nov 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #272
Allows for resolving Stylelint installed using Yarn with PnP, bypassing the need for Yarn to patch vscode-stylelint's configuration as it does now.
PnP resolution logic