Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension incorrectly shows Stylelint deprecation warning with Yarn PnP integration #275

Closed
jecassis opened this issue Oct 25, 2021 · 0 comments · Fixed by #278
Closed

Extension incorrectly shows Stylelint deprecation warning with Yarn PnP integration #275

jecassis opened this issue Oct 25, 2021 · 0 comments · Fixed by #278
Assignees
@adalinesimonian
Labels
good first issue is good for newcomers type: bug a problem with a feature or rule
Milestone
v1.1.0

Comments

@jecassis
Copy link

While I see that #273 and #272 are in flight, with the current integration and 14.0.0 released, there is a notification saying the following:

Stylelint version 14.0.0-sdk is no longer supported — you may encounter unexpected behavior. Please upgrade to version 14.0.0 or newer. See the migration guide for more information.

I believe it is due to this semver check. Coercion might be needed as any suffixed version by PnP that "should" match exactly will instead be considered to be older.
@adalinesimonian adalinesimonian added good first issue is good for newcomers status: ready to implement is ready to be worked on by someone type: bug a problem with a feature or rule labels Oct 25, 2021
@adalinesimonian adalinesimonian added this to the v1.1.0 milestone Oct 25, 2021
adalinesimonian added a commit that referenced this issue Oct 25, 2021
@adalinesimonian
fix: don't warn usage of stylelint 14.x-label
49edc32 
Fixes #275
@adalinesimonian adalinesimonian mentioned this issue Oct 25, 2021
Merged
@adalinesimonian adalinesimonian added status: wip is being worked on by someone and removed status: ready to implement is ready to be worked on by someone labels Oct 25, 2021
@adalinesimonian adalinesimonian changed the title Message due to Yarn PnP integration Extension incorrectly shows Stylelint deprecation warning with Yarn PnP integration Oct 25, 2021
@adalinesimonian adalinesimonian self-assigned this Oct 25, 2021
adalinesimonian added a commit that referenced this issue Oct 27, 2021
@adalinesimonian
fix: don't warn usage of stylelint 14.x-label (#278)
5445b1c 
Fixes #275
@adalinesimonian adalinesimonian added Fixed and removed status: wip is being worked on by someone labels Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adalinesimonian adalinesimonian

Labels
good first issue is good for newcomers type: bug a problem with a feature or rule
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

fix: don't warn usage of stylelint 14.x-label stylelint/vscode-stylelint
2 participants
@jecassis @adalinesimonian