Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand Travis matrix to use Webpack v3 and v4 #904

Merged
merged 22 commits into from
Mar 31, 2018
Merged

Conversation

okonet
Copy link
Member

@okonet okonet commented Mar 29, 2018

And use Travis CI Build Stages feature to simplify .travis.yml

Closes #902

@okonet okonet requested a review from sapegin March 29, 2018 19:04
@okonet okonet force-pushed the build-travis-ci-stages branch from 522ef41 to 5ef4e1e Compare March 29, 2018 19:13
package.json Outdated
@@ -146,6 +146,7 @@
"precompile": "rimraf lib/",
"compile": "babel --ignore '*.spec.js' -d lib/ src/",
"compile:watch": "babel --ignore '*.spec.js' --watch -d lib/ src/",
"prebuild": "npm run compile",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we can remove prepare script.

.travis.yml Outdated
script:
# Run lint
- npm run lint
- echo $WEBPACK_VERSION
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be more clear to prefix with webpack.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's for debugging purposes. I'll remove once it's done

.travis.yml Outdated
script:
- npm install -g semantic-release
- npm install --no-save semantic-release-tamia
- semantic-release --analyze-commits
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it work without \?

.travis.yml Outdated
- semantic-release-tamia/generateNotes
- |
# Update site
if [[ "$TRAVIS_BRANCH" == "master" ]]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need this anymore, covered by documentation stage.

@okonet okonet force-pushed the build-travis-ci-stages branch from 5ef4e1e to 112fac2 Compare March 29, 2018 19:17
@styleguidist-bot
Copy link
Collaborator

styleguidist-bot commented Mar 29, 2018

Warnings
⚠️

Changes were made to package.json, but not to package-lock.json.

Perhaps you need to run npm install and commit changes in package-lock.json. Make sure you’re using npm 5+.

Generated by 🚫 dangerJS

@okonet okonet force-pushed the build-travis-ci-stages branch from 8b93aa3 to 8b0a5f6 Compare March 30, 2018 18:14
@sapegin sapegin added this to the 7.0.0 milestone Mar 30, 2018
@okonet
Copy link
Member Author

okonet commented Mar 30, 2018

@sapegin some integration tests are failing. Can you point me into the right direction?

@codecov-io
Copy link

codecov-io commented Mar 31, 2018

Codecov Report

Merging #904 into master will not change coverage.
The diff coverage is 80%.

Impacted Files Coverage Δ
scripts/make-webpack-config.js 95.45% <80%> (ø) ⬆️

@sapegin sapegin merged commit 7dbb284 into master Mar 31, 2018
@sapegin sapegin deleted the build-travis-ci-stages branch March 31, 2018 17:23
sapegin added a commit that referenced this pull request Mar 31, 2018
👋 **[Support Styleguidist](https://opencollective.com/styleguidist) on Open Collective** 👋

## Breaking changes

### Node 6 is the lowest supported version

Styleguidist doesn’t support Node 4 anymore.

(#744 #839 by @kohgpat)

### New format of template option

We’re now using [mini-html-webpack-plugin](https://github.com/styleguidist/mini-html-webpack-plugin) and [@vxna/mini-html-webpack-template](https://github.com/vxna/mini-html-webpack-template) instead of [html-webpack-plugin](https://github.com/jantimon/html-webpack-plugin).

This will make things like [adding a favicon](https://react-styleguidist.js.org/docs/cookbook#how-to-add-a-favicon) or fonts from [Google Fonts](https://react-styleguidist.js.org/docs/cookbook#how-to-add-fonts-from-google-fonts) much easier.

If you’re using a custom HTML template, you need to update your style guide config.

```js
// 6.x
module.exports = {
  template: './styleguie/template.html'
}

// 7.x
module.exports = {
  template: {
    // This is just an example, there are many more available options
    favicon: 'https://assets-cdn.github.com/favicon.ico'
  }
}
```

See more [in the docs](https://react-styleguidist.js.org/docs/configuration#template).

(#896 #907 by @sapegin)

### Changed Node API

`server` method now returns an object containing a webpack `Compiler` instance and the Styleguidist server, see examples [in the docs](https://react-styleguidist.js.org/docs/api.html#servercallback).

(#828 by @cmswalker)

## New features

### Webpack 4 support

Webpack 3 is still supported too.

(#857 by @kontrollanten, #900 #901 by @rubenmoya)

### Examples are wrapped in React.Fragment

You don’t need to wrap multiple JSX tags in a div anymore.

```jsx
// 6.x
<div>
  <Button primary>Primary button</Button>
  <Button secondary>Secondary button</Button>
</div>

// 7.x
<Button primary>Primary button</Button>
<Button secondary>Secondary button</Button>
```

(#840 #842 by @tizmagik)

## Bug fixes

* `components` option should accept arrays.
* Do not convert URLs in Markdown to auto links (#793).
* Improved accessibility (#893 by @gergely-nagy).

---

❤️ Huge thanks to @okonet to help with this release, [CI](#904) and [docs](#905) improvements.️ ❤️
@styleguidist-bot
Copy link
Collaborator

🎉 This PR is included in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

valentyn90 pushed a commit to valentyn90/React-Styleguidist that referenced this pull request Oct 28, 2021
👋 **[Support Styleguidist](https://opencollective.com/styleguidist) on Open Collective** 👋

## Breaking changes

### Node 6 is the lowest supported version

Styleguidist doesn’t support Node 4 anymore.

(#744 #839 by @kohgpat)

### New format of template option

We’re now using [mini-html-webpack-plugin](https://github.com/styleguidist/mini-html-webpack-plugin) and [@vxna/mini-html-webpack-template](https://github.com/vxna/mini-html-webpack-template) instead of [html-webpack-plugin](https://github.com/jantimon/html-webpack-plugin).

This will make things like [adding a favicon](https://react-styleguidist.js.org/docs/cookbook#how-to-add-a-favicon) or fonts from [Google Fonts](https://react-styleguidist.js.org/docs/cookbook#how-to-add-fonts-from-google-fonts) much easier.

If you’re using a custom HTML template, you need to update your style guide config.

```js
// 6.x
module.exports = {
  template: './styleguie/template.html'
}

// 7.x
module.exports = {
  template: {
    // This is just an example, there are many more available options
    favicon: 'https://assets-cdn.github.com/favicon.ico'
  }
}
```

See more [in the docs](https://react-styleguidist.js.org/docs/configuration#template).

(#896 #907 by @sapegin)

### Changed Node API

`server` method now returns an object containing a webpack `Compiler` instance and the Styleguidist server, see examples [in the docs](https://react-styleguidist.js.org/docs/api.html#servercallback).

(#828 by @cmswalker)

## New features

### Webpack 4 support

Webpack 3 is still supported too.

(#857 by @kontrollanten, #900 #901 by @rubenmoya)

### Examples are wrapped in React.Fragment

You don’t need to wrap multiple JSX tags in a div anymore.

```jsx
// 6.x
<div>
  <Button primary>Primary button</Button>
  <Button secondary>Secondary button</Button>
</div>

// 7.x
<Button primary>Primary button</Button>
<Button secondary>Secondary button</Button>
```

(#840 #842 by @tizmagik)

## Bug fixes

* `components` option should accept arrays.
* Do not convert URLs in Markdown to auto links (#793).
* Improved accessibility (#893 by @gergely-nagy).

---

❤️ Huge thanks to @okonet to help with this release, [CI](styleguidist/react-styleguidist#904) and [docs](styleguidist/react-styleguidist#905) improvements.️ ❤️
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants